fix(fvm/windows): append '.bat' extention to flutter path#468
Merged
sidlatau merged 1 commit intonvim-flutter:mainfrom May 8, 2025
Merged
fix(fvm/windows): append '.bat' extention to flutter path#468sidlatau merged 1 commit intonvim-flutter:mainfrom
sidlatau merged 1 commit intonvim-flutter:mainfrom
Conversation
Collaborator
|
Thanks for the fix! I had simmilar PR ( #386 ) but was not able to test it. |
sidlatau
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The plugin does not work with FVM on Windows. I tested this on two separate projects using Flutter versions 3.16.0 and 3.27.0.
When running the
FlutterRuncommand, the following error occurs:This happens because the plugin tries to run flutter directly, but on Windows the actual executable is
flutter.bat.Solution
If
path.is_windows == true, we now append.batto the path of the flutter binary. This fixes the issue and allows flutter-tools.nvim to work correctly with FVM on Windows.I've been using this fix for several weeks without issues.
Environment
OS: Windows 11 Home
fvm: v3.2.1
flutter-tools.nvim: 8fa438f
Neovim: v0.10.4
Minimal Config to Reproduce