Clarify comment in .gitignore for lazy-lock.json#1896
Merged
oriori1703 merged 1 commit intonvim-lua:masterfrom Feb 27, 2026
Merged
Clarify comment in .gitignore for lazy-lock.json#1896oriori1703 merged 1 commit intonvim-lua:masterfrom
oriori1703 merged 1 commit intonvim-lua:masterfrom
Conversation
The current comment in .gitignore for lazy-lock.json suggests to uncomment it yourself, but you actually need to comment it instead. This change modifies the comment to clarify the recommended approach for kickstart users.
Collaborator
|
Makes sense :) |
rmacklin
reviewed
Feb 28, 2026
| # but for kickstart, it makes sense to leave it ignored. | ||
| # You likely want to comment this, since it's recommended to track lazy-lock.json in version | ||
| # control, see https://lazy.folke.io/usage/lockfile | ||
| # For kickstart, it makes sense to leave it ignored. |
Contributor
There was a problem hiding this comment.
I'd suggest a slight further clarification:
Suggested change
| # For kickstart, it makes sense to leave it ignored. | |
| # For the canonical kickstart git repository, it makes sense to leave it ignored. |
since otherwise it could be confusing for someone who interprets kickstart to more generally refer to this base set of nvim configuration they start from.
Contributor
There was a problem hiding this comment.
Opened a PR here (slightly improved from what I suggested above): #1914
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current comment in .gitignore for lazy-lock.json suggests to uncomment it yourself, but you actually need to comment it instead.
This change modifies the comment to clarify the recommended approach for kickstart users.