Use Telescope builtin functions for LSP definition and type definition

[theopn]

I thought it was a little odd that every other LSP features use Telescope builtin but not those two. It will allow easier navigation when there are multiple symbol definitions.

We can also potentially do something like the following snippet to be safer and provide an example of pcall:

  -- ...
  local status, builtin = pcall(require, 'telescope.builtin')
  if status then
    nmap('gd', builtin.lsp_definitions, '[G]oto [D]efinition')
    -- ...
  else
    nmap('gd', vim.lsp.buf.definition, '[G]oto [D]efinition')
    -- ...
  end

Although I am not sure it will be necessary since Telescope is very widely used in Kickstart and it might clutter the config and confuse beginners.

[maxwelbm]

Thanks for the suggestion

[one2three4f]

I thought it was strange the gd key wasn't working with this lsp https://github.com/Feel-ix-343/markdown-oxide , for some reason telescope's gd does not behave the same way vim's.

took a peek and lunar vim also keeps native gd.
https://github.com/LunarVim/LunarVim/blob/9ee3b7b8846d7ed2fa79f03d67083f8b95c897f2/lua/lvim/lsp/config.lua#L88

edit:
seems to be fixed soon:
nvim-telescope/telescope.nvim#2768