Breaking change: renamed Julian date constants and removed other Julian date constants#307
Merged
ChristopherRabotin merged 2 commits intomasterfrom Jun 9, 2024
Conversation
- J1900_NAIF -> JD_J1900 - J2000_NAIF -> JD_J2000 - J1900_OFFSET -> MJD_J1900 - J2000_OFFSET -> MJD_J12000 Removed constants (unused): - J2000_TO_J1900_DURATION - JDE_OFFSET_DAYS - JDE_OFFSET_SECONDS
ChristopherRabotin
deleted the
282-j1900-and-j2000-references-mix-up-causing-older-julian-dates-to-be-wrong
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a regression test to ensure that the printing of dates initialized from MJD is as expected. Clarified in the test that Hifitime's "prime epoch" is at midnight on 1900-01-01, so 0.5 days off of J1900. This behavior matches NAIF SPICE, which is an important property of hifitime as it is used to replace SPICE for time computations.
Renamed the following constants
Removed constants (unused):
Closes #282