Replaces this repo with new-snarkyjs from monorepo#2
Merged
MartinMinkov merged 46 commits intomasterfrom Oct 13, 2021
Merged
Conversation
bkase
changed the title
jasongitmail
reviewed
Sep 2, 2021
Contributor
There was a problem hiding this comment.
Some thoughts:
on: [push, pull_request]would allow this to run when a PR is proposed too- Should we run tests in this action too?
- Now that this isn't on the monorepo, Yarn isn't needed. What do you think about using NPM for consistency? It's NBD either way. But since NPM caught up & exceeded Yarn in speed, I'm not sure if there is any advantage to remaining with Yarn.
Edit: it looks like we havepackage-lock.jsonin the repo, so we should use NPM in that case. We can usenpm ciduring install in that case.
Contributor
Author
|
We should run tests when they pass (but currently they don't 😄 , this should be fixed when @mrmr1993 handles the node side) |
jasongitmail
approved these changes
Sep 7, 2021
jasongitmail
reviewed
Sep 7, 2021
.github/workflows/build-action.yml
Outdated
| with: | ||
| node-version: '14' | ||
| cache: 'yarn' | ||
| - run: npm install |
Contributor
There was a problem hiding this comment.
We should use npm ci instead of npm install. It will install the versions shown in package-lock.json (for consistency) & will be faster.
* Support building for node * Added production and development webpack configuation files for both node and web versions * Moved the node_bindings under /src and removed nodejs dir * Removed not needed scripts * Updated package.json to use new webpack configs
…kyjs into feature/snarkyjs-node-build
Build SnarkyJS for Node and Web under one package
mitschabaude
added a commit
that referenced
this pull request
Sep 5, 2023
Rebrand to o1js in snarkyjs repo (code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port from the monorepo with a GitHub action for CI
For reviewers -- you can focus on the "adds github action" commit, the other commits are just removing files and adding files from the monorepo