Allow specification of ingressClassName#56
Merged
pierluigilenoci merged 1 commit intooauth2-proxy:mainfrom Aug 25, 2021
jonkerj:ingressclassname
Merged
Allow specification of ingressClassName#56pierluigilenoci merged 1 commit intooauth2-proxy:mainfrom jonkerj:ingressclassname
pierluigilenoci merged 1 commit intooauth2-proxy:mainfrom
jonkerj:ingressclassname
Conversation
pierluigilenoci
previously approved these changes
Aug 24, 2021
Member
|
@jonkerj could you please check your changes and lint the chart to fix the issue? |
Signed-off-by: Jorik Jonker <jorik@kippendief.biz>
Contributor
Author
|
whoops, my bad. Retry! |
pierluigilenoci
approved these changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart does not allow users to specify
ingressClassName. In k8s 1.22, you either need to specify this name, or have an ingress class marked as default. This PR lets users specify the ingress class name in the resource through Helm.