Skip to content

Feature/sensor data control#202

Merged
thias15 merged 16 commits into
ob-f:masterfrom
dhruv2295:feature/sensorDataControl
Jul 22, 2021
Merged

Feature/sensor data control#202
thias15 merged 16 commits into
ob-f:masterfrom
dhruv2295:feature/sensorDataControl

Conversation

@dhruv2295

Copy link
Copy Markdown
Contributor

Sensor data control from dialog inside logger screen

@dhruv2295 dhruv2295 force-pushed the feature/sensorDataControl branch from 75dbb44 to 4cd7c32 Compare June 19, 2021 19:29
@thias15

thias15 commented Jun 24, 2021

Copy link
Copy Markdown
Collaborator

There are several issues:

  1. In landscape the dialog is not cut off and some options are not visible
  2. Typo: Dimiss should be Dismiss or maybe even better Cancel
  3. Starting logging will crash the app
2021-06-24 21:51:33.489 25155-25155/org.openbot E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.openbot, PID: 25155
    java.lang.NullPointerException: Attempt to invoke virtual method 'java.io.Writer java.io.BufferedWriter.append(java.lang.CharSequence)' on a null object reference
        at org.openbot.logging.SensorService.appendLog(SensorService.java:460)
        at org.openbot.logging.SensorService.onSensorChanged(SensorService.java:302)
        at android.hardware.SystemSensorManager$SensorEventQueue.dispatchSensorEvent(SystemSensorManager.java:883)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:363)
        at android.os.Looper.loop(Looper.java:176)
        at android.app.ActivityThread.main(ActivityThread.java:8393)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1055)

@thias15 thias15 linked an issue Jul 22, 2021 that may be closed by this pull request
@thias15 thias15 removed a link to an issue Jul 22, 2021
@thias15 thias15 self-assigned this Jul 22, 2021
@thias15 thias15 merged commit 468ccb7 into ob-f:master Jul 22, 2021
@dhruv2295 dhruv2295 deleted the feature/sensorDataControl branch September 13, 2021 07:09
lacykaltgr pushed a commit to satinavrobotics/SatiBot that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants