on model delete, do not remove it from model management list#227
Merged
Conversation
thias15
reviewed
Sep 25, 2021
thias15
left a comment
thias15
left a comment
Collaborator
There was a problem hiding this comment.
This works for the object detector models where a model with download url exists. But it creates another issue. Autopilot models that were added from the server can no longer be deleted. The dialog will show up, but after deletion they still show up in the model manager. The tflite model is null though, so they cannot be used.
dhruv2295
force-pushed
the
hotfix/modelManagement
branch
from
c40fb19 to
a0a42ed
Compare
thias15
approved these changes
Dec 20, 2021
lacykaltgr
pushed a commit
to satinavrobotics/SatiBot
that referenced
this pull request
Jun 1, 2025
on model delete, do not remove it from model management list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.