Multi-Terrain Vehicle (MTV)#278
Conversation
|
What are the small files like |
|
Agreed. |
|
Great. One more things is that we should compress the images where possible. Since there are many images it will blow up the repo size. For example |
|
Agreed. I converted the MTV pictures into .jpg |
thias15
left a comment
thias15
left a comment
There was a problem hiding this comment.
I left a comment in the README. Also the changes to the firmware for supporting the MTV are still missing.
|
|
||
| The ESP32 low-level control board communicates with the smartphone through a dedicated serial-USB interface. The command strings have the following structure: | ||
|
|
||
| - | **Drive letter** | **LHS speed** | **RHS speed** | |
There was a problem hiding this comment.
This section here should probably be removed. We will control it with our OpenBot firmware. But the description of this should probably be in the main README file.
|
The explanation about firmware in the MTV README should move to the firmware README file into a new section that explains how to use ESP32 boards. It is not specific to the MTV. |
|
Makes sense. |
thias15
left a comment
thias15
left a comment
There was a problem hiding this comment.
See comments in the code. In addition I think docs/images/MTV/Comp_arch.jpg is redundant. There is svg and jpeg of the same thing.
| @@ -74,6 +76,7 @@ boolean coast_mode = 1; | |||
| // HAS_BUMPER Enable/Disable bumper (1,0) | |||
| // HAS_SPEED_SENSORS_FRONT Enable/Disable front speed sensors (1,0) | |||
| // HAS_SPEED_SENSORS_BACK Enable/Disable back speed sensors (1,0) | |||
| // HAS_SPEED_SENSORS_MIDDLE Enable/Disable middle speed sensors (1,0) | |||
There was a problem hiding this comment.
Indent should be the same as for other items.
| const int PIN_DIR_L = 32; | ||
|
|
||
| // Encoder setup: | ||
| const int PIN_SPEED_RF_A = 14; |
There was a problem hiding this comment.
Not sure if it makes sense to define all of these. Maybe we should just define PIN_SPEED_LF etc. directly and behind it just leave a comment that specifies pin for A and B?
There was a problem hiding this comment.
I agree. I corrected that.
* added MTV content * removed duplicate copy of the phone mount * reduce image file size * integrated MTV firmware Co-authored-by: Matthias Mueller <thias15@web.de>
2 participants
Including the Multi-Terrain Vehicle (MTV) as an additional OpenBot platform.