Vehicle screen#296
Merged
Merged
Conversation
thias15
commented
Oct 14, 2022
Collaborator
Author
thias15
left a comment
There was a problem hiding this comment.
resolve merge conflict
Collaborator
Author
|
@quentin-leboutet please test and review. |
quentin-leboutet
approved these changes
Nov 16, 2022
Collaborator
quentin-leboutet
left a comment
There was a problem hiding this comment.
Tested on RTR_TT, RTR_520, MTV and RC_TRUCK. This is minor but maybe the LED slider should be greyed out or set to 0 when LEDs are not available on the vehicle? I'm also gonna generate a gif for the new design of the RC_TRUCK. Otherwise looks great !
lacykaltgr
pushed a commit
to satinavrobotics/SatiBot
that referenced
this pull request
Jun 1, 2025
Vehicle screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New screen that shows which vehicle is connected and what features it supports (based on firmware info).