Skip to content

Adding BLE support on Android Device + DPAD controller Connection#330

Merged
thias15 merged 45 commits into
ob-f:masterfrom
3dwesupport:android-ble
Apr 7, 2023
Merged

Adding BLE support on Android Device + DPAD controller Connection#330
thias15 merged 45 commits into
ob-f:masterfrom
3dwesupport:android-ble

Conversation

@sparsh3dwe

Copy link
Copy Markdown
Collaborator

No description provided.

@thias15

thias15 commented Jan 26, 2023

Copy link
Copy Markdown
Collaborator

> Task :app:testDebugUnitTest FAILED

@sparsh3dwe

Copy link
Copy Markdown
Collaborator Author

> Task :app:testDebugUnitTest FAILED

added null checks to fix the failures

sparsh3dwe and others added 14 commits February 15, 2023 16:38
Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.17.1...4.18.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.23 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](faisalman/ua-parser-js@0.7.23...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@thias15

thias15 commented Mar 12, 2023

Copy link
Copy Markdown
Collaborator

Added a few more fixes. Also noticed that the jpeg images for the README are not pushed to this PR. Please add them after compressing them.

@thias15 thias15 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README needs images and potentially some adjustments. Still need to test functionality - requires firmware from #329

Comment on lines 278 to 279

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these set to null here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, there was a bug into the application, which is being fixed here by reinitializing the variables.

Bug was if you turn on the auto mode into the autopilot, then move to settings by clicking on the usb/ble icon and come back to the fragment.

it crashes.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍. One 🐛 less!

Comment thread android/app/src/main/java/org/openbot/vehicle/Vehicle.java Outdated

@thias15 thias15 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested. Just need to adjust README with updated text and screenshots.

@thias15 thias15 merged commit 57fe9cb into ob-f:master Apr 7, 2023
lacykaltgr pushed a commit to satinavrobotics/SatiBot that referenced this pull request Jun 1, 2025
…-f#330)

* adding all the changes for bluetooth for ble connection, sending data to ble device and managing devices.

* commenting extra toasts

* adding null checks

* upgrade android api

* upgrade android sdk version of controller and gradle lint build failed issue solved

* update python style

* Bump express from 4.17.1 to 4.18.2 in /policy/frontend

Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.17.1...4.18.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump ua-parser-js from 0.7.23 to 0.7.33 in /policy/frontend

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.23 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](faisalman/ua-parser-js@0.7.23...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* adding all the changes for bluetooth for ble connection, sending data to ble device and managing devices.

* cleanup

* update firmware

* ui fixes

* fix bluetooth connecting issue

* fix in bluetooth connectivity in android 12 and above

* fix issue in autopilot fragment and object navigation fragment when get back from bluetooth device list screen

* fix readme images

* push screen shots of ble connections

* compress images and simplify README

* finetuning

* bt icon blue when connected

* implement separate usb fragment and change navigation from all fragment usb icon and remove usb connection activities from settings fragment

* apply app style

* clean-up

* use MAX_MSG_SZ

* clean-up

* increase MTU size in BLE and set BLE icon issue in Robot info screen

* increase MTU size to get maximum string

* minor tweaks

* update readme

* fix style

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Sanjeev Sharma <>
Co-authored-by: thias15 <thias15@web.de>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants