Skip to content

Fix dataloader and dependencies#337

Merged
thias15 merged 13 commits into
masterfrom
thias15/fix-dependencies
Feb 23, 2023
Merged

Fix dataloader and dependencies#337
thias15 merged 13 commits into
masterfrom
thias15/fix-dependencies

Conversation

@thias15

@thias15 thias15 commented Feb 16, 2023

Copy link
Copy Markdown
Collaborator
  • make sure the training environments are consistent across different OS
  • improve README to explain setup with GPU
  • bugfix in dataloader

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@thias15 thias15 changed the title Fix dependencies Fix dataloader and dependencies Feb 17, 2023

@quentin-leboutet quentin-leboutet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm testing it on W10, Ubuntu 22 and Mac (intel + arm). I will approve this PR as soon as I'm sure everything works on each platform.

@quentin-leboutet

Copy link
Copy Markdown
Collaborator

Update: successfully tested on W10 and iOS (apple M1). Did not work out of the box on Ubuntu 22. I had to manually install a specific version the driver (nvidia-driver-495) along with the cuda-toolkit and cudnn packages of the main ubuntu repo:
sudo apt-get install cuda-toolkit && sudo apt-get install nvidia-driver-510 && sudo apt-get install nvidia-cudnn

@thias15

thias15 commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator Author

I see. Any suggestions how it might work out of the box on Ubuntu? I tested it on a Linux cluster and it worked well there.

@quentin-leboutet

Copy link
Copy Markdown
Collaborator

Solved. Adding “export LD_LIBRARY_PATH=/path/to/anaconda3/envs/openbot/lib:$LD_LIBRARY_PATH” to the .bashrc to point to the correct versions of the libraries seems to do the trick. I'm validating this PR as not so many changes are required.

@thias15 thias15 merged commit 496a86f into master Feb 23, 2023
@thias15 thias15 deleted the thias15/fix-dependencies branch April 1, 2023 11:21
lacykaltgr pushed a commit to satinavrobotics/SatiBot that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants