Mirror the target control of ObjectNavFragment if front facing camera is used#386
Conversation
|
The convention for the front camera varies across phones. How about adding an icon to mirror controls next to the camera flip icon. |
|
OK, I haven't tried phones other than Samsung's. Maybe a better solution would be to detect the convention for the phone automatically, and set default value accordingly, in addition to adding icon to mirror control? Not sure if it's detectable. Before figuring out that, adding icon to mirror control can be a basic solution. I'll add some more commits soon |
…con to mirror controls next to the camera flip icon, instead of always mirroring control when using front camera.
|
I've added more commits. It should be ok now. |
|
I adjusted the layout and appearance of icons, now it looks like this: |
|
I have fixed the UI for the fragment. Could you review and replace below file named And also replace below file named |
… is used (ob-f#386) - Mirror the target control of ObjectNavFragment if front facing camera is used - The convention for the front camera varies across phones. Adding an icon to mirror controls next to the camera flip icon, instead of always mirroring control when using front camera.
5 participants
When front facing camera is used, the target control of ObjectNavFragment should be mirrored otherwise the bot can't follow the target object. See the issue 385 for detail