Skip to content
This repository was archived by the owner on May 12, 2025. It is now read-only.

various improvements#109

Open
obfusk wants to merge 63 commits intomasterfrom
v1sig
Open

various improvements#109
obfusk wants to merge 63 commits intomasterfrom
v1sig

Conversation

@obfusk
Copy link
Owner

@obfusk obfusk commented Dec 24, 2024 •
edited
Loading

fixes #28
fixes #45
fixes #55
fixes #58
fixes #67
fixes #80
fixes #88
fixes #91

  • improve validation
  • update test APKs
  • update manpage and changelog
  • update README

obfusk added 24 commits December 22, 2024 00:12
@obfusk
use DIFF_JSON variable
2b5ac9c
@obfusk
add legacy options (still unused for now)
89393a0
@obfusk
add extract_v1_sig() etc. & split off various functions for reuse
b9ab22a
@obfusk
use new v1_sig format
6e0b051
@obfusk
drop support for Python 3.7
b3e1c6e
@obfusk
cleanup
92778e8
@obfusk
update test
9d2d269
@obfusk
validate ZIP headers
623f10d
@obfusk
CI: test legacy
b9150fe
@obfusk
CI: fix
469f1f5
@obfusk
check v1 signature entries are at end of archive
d2eeb09
@obfusk
only check v1 at end of archive when v2 is present; refactor
1943038
@obfusk
extract_v1_sig(): fix return value when there are no entries
f161164
@obfusk
support v1 signature after manifest (fixes #80, improves #88)
9662ad7
@obfusk
README++ [skip ci]
fdc17a9
@obfusk
put zfe_size in v1signature.zip, refactor, update CI
8c9f485
@obfusk
do_patch() fix handling missing v2/v3 signature
1667505
@obfusk
copy_apk() use max comment size of 65536 for seek just in case
fd142b9
@obfusk
put JSON w/ offsets in v1signature.zip & refactor (fixes #88)
40a2d72
@obfusk
add (legacy) to docstrings [skip ci]
3866cc0
@obfusk
use raw docstrings for those w/ doctests [skip ci]
4b5257a
@obfusk
compare: check SHA-256 & add --no-check-{signature,sha256}
90df1ce
@obfusk
clean up doctests (rm imports)
85b2011
@obfusk
fix legacy tests & use --no-check-sha256
e36db7b
@obfusk obfusk self-assigned this Dec 24, 2024
@obfusk obfusk changed the title v1 signature improvements various improvements Dec 24, 2024
@obfusk

This comment was marked as outdated.

Sign in to view
obfusk added 14 commits December 26, 2024 18:23
@obfusk
main(): remove redundant is_flag=True for --(no-)legacy
ee5c161
@obfusk
validate indices and offsets and return them from extract_v1_sig_data()
0354c2f
@obfusk
patch_v2_sig(): raise error if sb_offset requires > 64k padding
4e51fe0
@obfusk
use \A & \Z for APK_META (is_meta() is unchanged as it uses .fullmatc…
7dd870f 
…h())
@obfusk
is_meta()/APK_META: fix & add strict; validate_v1_sig(): check MAX_SI…
8f5499c 
…GNERS etc.
@obfusk
update tests
145c8df
@obfusk
add & use test/test-compare-self.out.build-tools.legacy.patch
70012fc
@obfusk
update JAR link [skip ci]
a27b5b8
@obfusk
validate_zip_header(): check for NUL/LF/CR and decoded match
234a431
@obfusk
use .orig_filename and .read(info)
fa5a20a
@obfusk
extract_meta() make strict kwonly
f3904c6
@obfusk
update compare example [skip ci]
9a37000
@obfusk
use :=
8482dcb
@obfusk
use .orig_filename.split("\x00", 1)[0] to avoid os.sep stuff
1a173e7
@obfusk
Copy link
Owner Author

obfusk commented Jan 8, 2025

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.