Skip to content

Fix CI test failures: syntax error and undefined schema references #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangyiirene merged 2 commits into from
Jan 20, 2026
Merged

Fix CI test failures: syntax error and undefined schema references #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be3dcc
Initial plan
Copilot Jan 20, 2026
6f94ae0
Fix test failures: remove extra brace and undefined MenuItem tests
Copilot Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/spec/src/data/field.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ describe('FieldSchema', () => {

expect(() => FieldSchema.parse(selectField)).not.toThrow();
});
});
});

describe('Relationship Fields', () => {
Expand Down
28 changes: 1 addition & 27 deletions packages/spec/src/system/manifest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,5 @@
import { describe, it, expect } from 'vitest';
import { ManifestSchema, MenuItemSchema, type ObjectStackManifest, type MenuItem } from './manifest.zod';

describe('MenuItemSchema', () => {
it('should accept minimal menu item', () => {
const menuItem: MenuItem = {
label: 'Dashboard',
path: '/dashboard',
};

expect(() => MenuItemSchema.parse(menuItem)).not.toThrow();
});

it('should accept menu item with icon', () => {
const menuItem: MenuItem = {
label: 'Settings',
path: '/settings',
icon: 'settings',
};

expect(() => MenuItemSchema.parse(menuItem)).not.toThrow();
});

it('should reject menu item without required fields', () => {
expect(() => MenuItemSchema.parse({ label: 'Test' })).toThrow();
expect(() => MenuItemSchema.parse({ path: '/test' })).toThrow();
});
});
import { ManifestSchema, type ObjectStackManifest } from './manifest.zod';

describe('ManifestSchema', () => {
describe('Basic Properties', () => {
Expand Down
Loading