Skip to content

Fix missing @objectstack/core dependency in examples/basic #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 5 commits into from
Feb 1, 2026
Merged

Fix missing @objectstack/core dependency in examples/basic #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd57d39
chore(deps)(deps-dev): bump @types/node from 20.19.30 to 25.0.10
dependabot[bot] Jan 29, 2026
11be921
Initial plan
Copilot Feb 1, 2026
7fd205d
fix: add missing @objectstack/core dependency and fix type assertion …
Copilot Feb 1, 2026
255ca92
Merge branch 'main' into copilot/update-documentation-for-actions-run
hotlong Feb 1, 2026
7189780
Merge branch 'main' into copilot/update-documentation-for-actions-run
hotlong Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@tailwindcss/postcss": "^4.1.18",
"@tailwindcss/typography": "^0.5.19",
"@types/negotiator": "^0.6.4",
"@types/node": "^20.10.0",
"@types/node": "^25.1.0",
"@types/react": "^19.2.8",
"@types/react-dom": "^19.2.3",
"autoprefixer": "^10.4.23",
Expand Down
2 changes: 1 addition & 1 deletion examples/ai-support/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@objectstack/spec": "workspace:*"
},
"devDependencies": {
"@types/node": "^20.10.0",
"@types/node": "^25.1.0",
"tsx": "^4.21.0",
"typescript": "^5.3.0"
}
Expand Down
2 changes: 1 addition & 1 deletion examples/basic/logger-example.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ async function examplePluginLogging() {
dependencies: ['database'],

init: async (ctx: PluginContext) => {
const db = ctx.getService('db') as any;
const db = ctx.getService('db') as { connected: boolean };
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type assertion used here bypasses TypeScript's type safety. The getService method is already generic and should be able to infer or accept a type parameter. Consider using the generic parameter instead of type assertion for better type safety.

For example, you could use: const db = ctx.getService<{ connected: boolean }>('db');

This would provide the same type information while maintaining the intent of the generic method and avoiding the use of as which can hide potential runtime errors.

Suggested change
const db = ctx.getService('db') as { connected: boolean };
const db = ctx.getService<{ connected: boolean }>('db');

Copilot uses AI. Check for mistakes.
ctx.logger.info('API plugin initialized', { dbConnected: db.connected });

ctx.registerService('api', { server: 'http://localhost:3000' });
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"license": "Apache-2.0",
"devDependencies": {
"@changesets/cli": "^2.27.1",
"@types/node": "^20.10.0",
"@types/node": "^25.1.0",
"tsx": "^4.21.0",
"typescript": "^5.3.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/ai-bridge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
},
"devDependencies": {
"typescript": "^5.3.3",
"@types/node": "^20.11.0"
"@types/node": "^25.1.0"
}
}
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"zod": "^3.22.4"
},
"devDependencies": {
"@types/node": "^20.11.19",
"@types/node": "^25.1.0",
"tsup": "^8.0.2",
"typescript": "^5.3.3"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"devDependencies": {
"typescript": "^5.0.0",
"vitest": "^1.0.0",
"@types/node": "^20.0.0"
"@types/node": "^25.1.0"
},
"dependencies": {
"@objectstack/spec": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/plugin-hono-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"hono": "^4.0.0"
},
"devDependencies": {
"@types/node": "^20.0.0",
"@types/node": "^25.1.0",
"typescript": "^5.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/plugins/plugin-msw/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"devDependencies": {
"@objectstack/runtime": "workspace:*",
"@types/node": "^20.0.0",
"@types/node": "^25.1.0",
"typescript": "^5.0.0"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/spec/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"author": "ObjectStack",
"license": "Apache-2.0",
"devDependencies": {
"@types/node": "^20.10.0",
"@types/node": "^25.1.0",
"@vitest/coverage-v8": "^2.1.8",
"tsx": "^4.21.0",
"typescript": "^5.3.0",
Expand Down
Loading