Fix metadata.get() returning wrapper instead of content#249
Merged
hotlong merged 3 commits intocopilot/fix-runtimeplugin-issuesfrom Jan 29, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with action run in CI workflow
Fix metadata.get() returning wrapper instead of content
Jan 29, 2026
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the ObjectQL core metadata stub so that it returns unwrapped metadata content, matching the original MetadataRegistry behavior and restoring downstream metadata tests (e.g., in the Express integration).
Changes:
- Added a local
unwrapContent()helper that mirrorsMetadataRegistry’s logic for returningitem.contentwhen present. - Updated the
metadata.get()stub to callSchemaRegistry.getItem()and return only the unwrappedcontent. - Updated the
metadata.list()stub to map the results ofSchemaRegistry.listItems()throughunwrapContent, so callers receive arrays of content objects rather than wrapper entries.
Comments suppressed due to low confidence (3)
packages/foundation/core/src/app.ts:24
- Unused imports LoaderPlugin, MetadataItem.
import {
MetadataRegistry,
MetadataItem,
Driver,
ObjectConfig,
ObjectQLContext,
ObjectQLContextOptions,
IObjectQL,
ObjectQLConfig,
HookName,
HookHandler,
HookContext,
ActionHandler,
ActionContext,
LoaderPlugin
} from '@objectql/types';
packages/foundation/core/src/app.ts:126
- Unused variable type.
for (const [type, collection] of metadata.entries()) {
packages/foundation/core/src/app.ts:445
- Unused variable key.
for (const [key, obj] of Object.entries(this.config.objects)) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metadata stub in
ObjectQLwas returning the internal wrapper object{type, id, path, package, content}instead of unwrapping to return just thecontentproperty. This causedapp.metadata.get('object', 'user')to return an object without the expectednamefield.Changes
unwrapContent()helper to extractcontentproperty from wrapped metadata itemsmetadata.get()stub to unwrap before returningmetadata.list()stub to map items through unwrapperThis aligns the SchemaRegistry-backed stub with the original
MetadataRegistrybehavior:Resolves CI failure in
examples/integrations/express-servermetadata tests.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fastdl.mongodb.org/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/objectql/objectql/node_modules/.pnpm/jest-worker@30.2.0/node_modules/jest-worker/build/processChild.js(dns block)fonts.googleapis.com/usr/local/bin/node node /home/REDACTED/work/objectql/objectql/apps/site/node_modules/.bin/../next/dist/bin/next build(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.