Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
…lish locales Add translated objectManager and fieldDesigner sub-sections to the appDesigner section in zh, ja, ko, de, fr, es, pt, ru, and ar locale files, matching the keys added to en.ts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
- Add type definitions (ObjectDefinition, DesignerFieldDefinition, etc.) in @object-ui/types - Implement ObjectManager component with CRUD, search, grouping, property editing - Implement FieldDesigner component with CRUD, field types, validation rules, advanced properties - Add i18n keys for all 10 locales (en, zh, ja, ko, de, fr, es, pt, ru, ar) - Export new components and types from @object-ui/plugin-designer - Register components in ComponentRegistry Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/143938d4-431c-4d1e-9017-8534ade7ff71 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
- Add 18 tests for ObjectManager, 22 tests for FieldDesigner - Create missing vitest.setup.ts for plugin-designer package - Add @object-ui/i18n alias to vite config (fixes 9 pre-existing test failures) - Update ROADMAP.md with P1.16 Object Manager & Field Designer section - Update CHANGELOG.md with new features and fixes Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/143938d4-431c-4d1e-9017-8534ade7ff71 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
|
@copilot 仔细评估是否完成的任务中要求的所有开发，并且已经集成到console |
There was a problem hiding this comment.
Pull request overview
Implements two new enterprise metadata-platform visual designers in @object-ui/plugin-designer (Object Manager + Field Designer), along with the supporting @object-ui/types schemas, i18n keys across all locales, and test infra updates so the plugin-designer test suite runs reliably.
Changes:
- Added
ObjectManagerandFieldDesignercomponents and registered them in the designer ComponentRegistry. - Extended
@object-ui/typeswith Object/Field designer types + schemas. - Added i18n keys (all 10 locales) + plugin-designer fallback translations; updated plugin-designer test setup and Vite aliasing.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/types/src/index.ts | Re-exports newly added designer-related types from designer.ts. |
| packages/types/src/designer.ts | Adds Object Manager + Field Designer type definitions and component schemas. |
| packages/plugin-designer/vitest.setup.ts | Adds jsdom polyfills (ResizeObserver + dialog methods) and jest-dom matchers for plugin-designer tests. |
| packages/plugin-designer/vite.config.ts | Adds @object-ui/i18n alias and wires vitest.setup.ts into Vitest config. |
| packages/plugin-designer/src/index.tsx | Exports and registers ObjectManager + FieldDesigner in ComponentRegistry. |
| packages/plugin-designer/src/hooks/useDesignerTranslation.ts | Adds fallback translations for new Object Manager / Field Designer keys. |
| packages/plugin-designer/src/tests/ObjectManager.test.tsx | Adds unit tests for ObjectManager rendering + CRUD-ish flows + read-only/system behaviors. |
| packages/plugin-designer/src/tests/FieldDesigner.test.tsx | Adds unit tests for FieldDesigner rendering + CRUD-ish flows + filtering + read-only/system behaviors. |
| packages/plugin-designer/src/ObjectManager.tsx | New Object Manager UI implementation (search, grouping, inline edit, delete confirm, system protection). |
| packages/plugin-designer/src/FieldDesigner.tsx | New Field Designer UI implementation (search, type filter, grouping, inline edit, options/rules editing, reorder buttons, delete confirm). |
| packages/i18n/src/locales/en.ts | Adds appDesigner.objectManager + appDesigner.fieldDesigner keys (English). |
| packages/i18n/src/locales/zh.ts | Adds appDesigner.objectManager + appDesigner.fieldDesigner keys (Chinese). |
| packages/i18n/src/locales/ja.ts | Adds appDesigner.objectManager + appDesigner.fieldDesigner keys (Japanese). |
| packages/i18n/src/locales/ko.ts | Adds appDesigner.objectManager + appDesigner.fieldDesigner keys (Korean). |
| packages/i18n/src/locales/de.ts | Adds appDesigner.objectManager + appDesigner.fieldDesigner keys (German). |
| packages/i18n/src/locales/fr.ts | Adds appDesigner.objectManager + appDesigner.fieldDesigner keys (French). |
| packages/i18n/src/locales/es.ts | Adds appDesigner.objectManager + appDesigner.fieldDesigner keys (Spanish). |
| packages/i18n/src/locales/pt.ts | Adds appDesigner.objectManager + appDesigner.fieldDesigner keys (Portuguese). |
| packages/i18n/src/locales/ru.ts | Adds appDesigner.objectManager + appDesigner.fieldDesigner keys (Russian). |
| packages/i18n/src/locales/ar.ts | Adds appDesigner.objectManager + appDesigner.fieldDesigner keys (Arabic). |
| ROADMAP.md | Marks Object Manager & Field Designer milestone as complete and documents deliverables. |
| CHANGELOG.md | Adds Unreleased entries for the new designers/types/i18n + test infra fix. |
| ### Fixed | ||
|
|
There was a problem hiding this comment.
The "Unreleased" section now contains two consecutive "### Fixed" headings (one added for the plugin-designer test infra fix, followed immediately by an existing "### Fixed"). Please merge these into a single "### Fixed" section to avoid duplicated headings and keep the changelog structure consistent.
| ### Fixed |
| <button | ||
| type="button" | ||
| onClick={() => moveField(field.id, 'up')} | ||
| disabled={readOnly || idx === 0} | ||
| className="rounded p-0.5 text-gray-400 hover:text-gray-700 disabled:opacity-30" | ||
| aria-label="Move up" | ||
| > | ||
| <ChevronUp className="h-3 w-3" /> | ||
| </button> | ||
| <button | ||
| type="button" | ||
| onClick={() => moveField(field.id, 'down')} | ||
| disabled={readOnly || idx === flds.length - 1} | ||
| className="rounded p-0.5 text-gray-400 hover:text-gray-700 disabled:opacity-30" | ||
| aria-label="Move down" | ||
| > | ||
| <ChevronDown className="h-3 w-3" /> | ||
| </button> |
There was a problem hiding this comment.
Field reordering (the move up/down controls calling moveField) is newly introduced behavior but isn’t covered by the FieldDesigner test suite. Adding tests that verify the order changes correctly within a group (and that sortOrder/group boundaries are respected) would help prevent regressions once the move logic is adjusted.
| const idx = fields.findIndex((f) => f.id === id); | ||
| if (idx < 0) return; | ||
| const target = direction === 'up' ? idx - 1 : idx + 1; | ||
| if (target < 0 || target >= fields.length) return; | ||
| const updated = [...fields]; | ||
| [updated[idx], updated[target]] = [updated[target], updated[idx]]; | ||
| onFieldsChange?.(updated); | ||
| }, | ||
| [fields, onFieldsChange] |
There was a problem hiding this comment.
moveField() reorders by swapping neighbors in the original fields array, but the UI renders groupedFields sorted by sortOrder and grouped by field.group. This can cause move up/down to (a) swap with a field from a different group, (b) appear to do nothing when sortOrder is set (sorting immediately restores the previous visual order), and (c) behave inconsistently when search/type filtering is active. Consider implementing moves in terms of the currently displayed group order and persisting the change by updating sortOrder within the affected group (or by deriving display order purely from the array order and not additionally sorting by sortOrder).
| const idx = fields.findIndex((f) => f.id === id); | |
| if (idx < 0) return; | |
| const target = direction === 'up' ? idx - 1 : idx + 1; | |
| if (target < 0 || target >= fields.length) return; | |
| const updated = [...fields]; | |
| [updated[idx], updated[target]] = [updated[target], updated[idx]]; | |
| onFieldsChange?.(updated); | |
| }, | |
| [fields, onFieldsChange] | |
| const movingField = fields.find((f) => f.id === id); | |
| if (!movingField) return; | |
| // Determine the logical group key (treat undefined group as a single ungrouped bucket) | |
| const groupKey = movingField.group ?? '__ungrouped__'; | |
| // Use the currently visible fields to determine ordering within the group | |
| const visibleGroupFields = filteredFields.filter( | |
| (f) => (f.group ?? '__ungrouped__') === groupKey | |
| ); | |
| const currentVisibleIndex = visibleGroupFields.findIndex((f) => f.id === id); | |
| if (currentVisibleIndex < 0) return; | |
| const targetVisibleIndex = direction === 'up' ? currentVisibleIndex - 1 : currentVisibleIndex + 1; | |
| if (targetVisibleIndex < 0 || targetVisibleIndex >= visibleGroupFields.length) return; | |
| const targetField = visibleGroupFields[targetVisibleIndex]; | |
| const movingHasSortOrder = typeof movingField.sortOrder === 'number'; | |
| const targetHasSortOrder = typeof targetField.sortOrder === 'number'; | |
| // If either field participates in sortOrder-based ordering, swap their sortOrder values | |
| if (movingHasSortOrder || targetHasSortOrder) { | |
| const movingOrder = movingHasSortOrder ? (movingField.sortOrder as number) : 0; | |
| const targetOrder = targetHasSortOrder | |
| ? (targetField.sortOrder as number) | |
| : movingHasSortOrder | |
| ? direction === 'up' | |
| ? movingOrder - 1 | |
| : movingOrder + 1 | |
| : 0; | |
| const updated = fields.map((f) => { | |
| if (f.id === movingField.id) { | |
| return { ...f, sortOrder: targetOrder }; | |
| } | |
| if (f.id === targetField.id) { | |
| return { ...f, sortOrder: movingOrder }; | |
| } | |
| return f; | |
| }); | |
| onFieldsChange?.(updated); | |
| return; | |
| } | |
| // Fallback: no sortOrder defined on either field; swap their positions in the fields array | |
| const movingIndex = fields.findIndex((f) => f.id === movingField.id); | |
| const targetIndex = fields.findIndex((f) => f.id === targetField.id); | |
| if (movingIndex < 0 || targetIndex < 0) return; | |
| const updated = [...fields]; | |
| [updated[movingIndex], updated[targetIndex]] = [updated[targetIndex], updated[movingIndex]]; | |
| onFieldsChange?.(updated); | |
| }, | |
| [fields, filteredFields, onFieldsChange] |
- Add ObjectManagerPage in apps/console/src/pages/system/ - Add /system/objects route to App.tsx (both fallback and app-scoped) - Add Object Manager card to SystemHubPage with object count - Add Object Manager link in AppSidebar system fallback navigation - Add ObjectManagerPage.test.tsx with 7 tests (all passing) - Update CHANGELOG.md with console integration entry Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/52331de5-5cd4-4b3d-90cd-d4c6084a5f52 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
已完成评估并补全了 console 集成。具体补充内容（commit 新增 Console 集成：
测试结果：
|
…th proper interfaces - Add MetadataObject and MetadataField interfaces for API data shapes - Update toObjectDefinition, toFieldDefinition, and find callback to use typed params - Remove all `any` type annotations Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/52331de5-5cd4-4b3d-90cd-d4c6084a5f52 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
|
@copilot 对象管理器的列表和表单为什么不用标准的对象组件，为什么要自己开发？ |
|
@copilot 更新代码解决合并冲突，并且当前对象列表有一个字段都没有 |
Resolve CHANGELOG.md conflict by combining both sections. Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
已修复。Commit
测试结果：plugin-designer 13/13 suites, 242 tests ✅ | console 57/57 suites, 757 tests ✅ |
|
@copilot 对象管理缺少记录详情页，没有看到字段管理的入口 |
…gement entry - Add /system/objects/:objectName route for object detail pages - ObjectManagerPage now uses URL-based routing (not state toggle) - Object detail view shows: properties card (API name, label, group, status, field count, relationships) + FieldDesigner for field management - Clicking object name in ObjectGrid navigates to detail URL - Back button returns to object list - Tests: 11 tests covering list view, detail view, URL navigation, properties, field management section, relationships, back navigation Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/d101c93c-eeee-40ac-9495-b85336c1f08f Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
…al state) Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/d101c93c-eeee-40ac-9495-b85336c1f08f Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
已添加对象详情页和字段管理入口。Commit
测试结果：console 57/57 suites, 761 tests ✅ | plugin-designer 13/13 suites, 242 tests ✅ |
|
@copilot 对象列表无法点击进入进入详情页 |
…/objects navigation
The ObjectManagerPage routes only existed in AppContent (for /apps/:appName/system/objects)
but not in the SystemRoutes component (for /system/objects). This meant clicking on objects
in the list triggered navigate('/system/objects/:objectName') correctly, but the route
wasn't handled, so the detail page never rendered.
Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/80a817a2-deca-4fe3-9ca5-17d26519d734
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
已修复。Commit 根本原因： 现已在 测试结果：console 57/57 suites, 761 tests ✅ |
|
@copilot 问题的关键是对象列表不能点击进入记录详情页呀 |
…igation Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/2766f2c6-b5ea-42f9-8327-dd8201c1afb7 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
ObjectGrid applies $select using only column fields, which strips the `id` property from records returned by ValueDataSource.find(). This caused handleRowClick, handleEdit, and handleDelete to fail silently since objects.find(o => o.id === record.id) always returned undefined. Fixed by matching on `name` (which IS in the grid columns) instead of `id` in both ObjectManager and FieldDesigner. Also strengthened the ObjectManagerPage click-to-navigate test to assert the detail view actually renders after clicking a primary-field-link. Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/2766f2c6-b5ea-42f9-8327-dd8201c1afb7 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
已修复。Commit 根本原因：ObjectGrid 内部使用 修复方案：ObjectManager 和 FieldDesigner 中所有记录查找从 测试结果：plugin-designer 13/13 suites, 242 tests ✅ | console 57/57 suites, 761 tests ✅ |
Enterprise-grade visual designers for managing object definitions and configuring fields — the core metadata platform tooling described in #1135. Fully integrated into the console application at
/system/objects.New Components
ObjectManager— CRUD on meta-object definitions using standardObjectGridfor the list view andModalFormfor create/edit operations. Features include property editing (name, label, plural label, description, icon, group, sort order, enabled), relationship display, search/filter, system object protection, confirm dialogs for destructive actions, and read-only mode.FieldDesigner— Field configuration wizard using standardObjectGridfor the list view with a specializedFieldEditorpanel for advanced type-specific properties. Supports 27 field types with uniqueness, defaults, picklist options, read-only, hidden, validation rules, external ID, history tracking, indexed. Type-specific editors for lookup references, formula expressions, and select options. Field type filtering, search, system field protection, and read-only mode.Console Integration
ObjectManagerPage— System admin page with URL-based routing:/system/objects— Object list view powered by ObjectManager with ObjectGrid/system/objects/:objectName— Object detail page showing an object properties card (API name, label, plural label, group, status, field count, relationships) with FieldDesigner embedded below as the field management sectionApp.tsx— Added lazy-loadedObjectManagerPageroutes for both/system/objectsand/system/objects/:objectNamein fallback (no-app) and app-scoped system route sectionsSystemHubPage— Added "Object Manager" card with Database icon and live object count badgeAppSidebar— Added "Object Manager" link in the system fallback navigationStandard Component Reuse
Both ObjectManager and FieldDesigner are built on top of standard ObjectUI components rather than custom-built list/form rendering:
ObjectGrid(@object-ui/plugin-grid) — Used for list views in both components, withValueDataSourcefor in-memory data managementModalForm(@object-ui/plugin-form) — Used for object create/edit operations in ObjectManager (usingcustomFieldsmode, no DataSource required)FieldEditorpanel — Specialized editor retained for FieldDesigner only, since advanced field-type-specific editing (options editor, validation rules, conditional lookup/formula/select configuration) cannot be replaced by standard form fieldsTypes (
@object-ui/types)ObjectDefinition,ObjectDefinitionRelationship,ObjectManagerSchema,DesignerFieldType(27 types),DesignerFieldOption,DesignerValidationRule,DesignerFieldDefinition,FieldDesignerSchemai18n
50 new keys per locale across all 10 locales (
objectManager+fieldDesignersections underappDesigner), with fallback translations inuseDesignerTranslation.Test Infrastructure Fix
vitest.setup.tsfor plugin-designer (ResizeObserver polyfill + jest-dom)@object-ui/i18nalias tovite.config.ts— unblocks 9 pre-existing broken test suitesTests
ObjectManager.test.tsx— 18 tests (rendering, CRUD via ObjectGrid+ModalForm, search, system object protection, read-only)FieldDesigner.test.tsx— 18 tests (rendering, CRUD via ObjectGrid+FieldEditor, type filter, inline editor, select options, read-only)ObjectManagerPage.test.tsx— 11 tests (list view rendering, detail view via URL routing, object properties card, field management section, back navigation, relationships display, ObjectGrid primary-field-link navigation)⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.