Skip to content

[WIP] Fix ag-grid documentation style import issue #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Jan 27, 2026
Merged

[WIP] Fix ag-grid documentation style import issue #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa1dab
Initial plan
Copilot Jan 27, 2026
32897d0
Add prebuild script to build workspace dependencies before building c…
Copilot Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/crm-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"type": "module",
"scripts": {
"dev": "vite",
"prebuild": "pnpm --filter @object-ui/types build && pnpm --filter @object-ui/core build && pnpm --filter @object-ui/react build && pnpm --filter @object-ui/components build && pnpm --filter @object-ui/fields build && pnpm --filter @object-ui/layout build && pnpm --filter @object-ui/plugin-dashboard build",
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This long sequential build command is difficult to maintain and error-prone. Consider these more maintainable alternatives:

  1. Use PNPM's built-in topological ordering: pnpm -r --filter='./packages/*' build will automatically build packages in the correct dependency order.

  2. Leverage Turbo (already installed at the root): Create a turbo.json configuration to manage build orchestration across the monorepo.

  3. Use PNPM's --filter with ellipsis syntax: pnpm --filter='@examples/crm-app^...' build will build all dependencies of crm-app.

The current approach requires manual updates whenever dependencies change and is inconsistent with the root package.json's build script (line 19 in root package.json) which uses -r for recursive topological builds.

Suggested change
"prebuild": "pnpm --filter @object-ui/types build && pnpm --filter @object-ui/core build && pnpm --filter @object-ui/react build && pnpm --filter @object-ui/components build && pnpm --filter @object-ui/fields build && pnpm --filter @object-ui/layout build && pnpm --filter @object-ui/plugin-dashboard build",
"prebuild": "pnpm --filter='@examples/crm-app^...' build",

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the custom coding guideline Rule #2 (Documentation Driven Development), this change should be documented. While this is an infrastructure fix for Vercel deployment, consider adding documentation about:

  1. How to build the monorepo for deployment
  2. The dependency order requirements
  3. Known deployment platform gotchas (like Vercel not auto-building workspace dependencies)

This could be added to CONTRIBUTING.md under a "Deployment" or "Building for Production" section, or in a README.md in the examples/crm-app directory.

Copilot generated this review using guidance from repository custom instructions.
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title mentions "ag-grid documentation style import issue" but the actual change is about fixing Vercel build orchestration for workspace dependencies. The change doesn't reference ag-grid at all. Please update the PR title to accurately reflect the changes, such as "Fix Vercel build by adding prebuild script for workspace dependencies".

Copilot uses AI. Check for mistakes.
"build": "tsc && vite build",
"preview": "vite preview"
},
Expand Down