Skip to content

Add passWithNoTests to vitest configurations#297

Merged
hotlong merged 2 commits intocopilot/fix-issue-in-object-uifrom
copilot/check-workflow-success
Jan 31, 2026
Merged

Add passWithNoTests to vitest configurations#297
hotlong merged 2 commits intocopilot/fix-issue-in-object-uifrom
copilot/check-workflow-success

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 31, 2026

Vitest exits with code 1 when no test files are found, failing CI for 10+ packages that have test scripts but no tests yet (create-plugin, plugin-calendar, plugin-chatbot, etc.).

Changes

  • Added passWithNoTests: true to root vitest.config.mts
  • Added test sections with passWithNoTests: true to 17 package-level vite.config.ts files

Packages without their own vite.config.ts already inherit from root config. Packages with vite.config.ts needed explicit test sections since vite config takes precedence over vitest config.

// packages/plugin-*/vite.config.ts
export default defineConfig({
  // ... build config
  test: {
    passWithNoTests: true,
  },
});
Original prompt

引用: https://github.com/objectstack-ai/objectui/actions/runs/21540165902/job/62073421138#step:7:1


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectui Ready Ready Preview, Comment Jan 31, 2026 6:47am
objectui-components Ready Ready Preview, Comment Jan 31, 2026 6:47am
objectui-crm-app Ready Ready Preview, Comment Jan 31, 2026 6:47am

Request Review

Add passWithNoTests: true to all vitest configurations to allow packages without test files to pass CI. This affects:
- Root vitest.config.mts
- All package-level vite.config.ts files with test sections

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Check success of workflow execution Add passWithNoTests to vitest configurations Jan 31, 2026
Copilot AI requested a review from hotlong January 31, 2026 06:44
@hotlong hotlong marked this pull request as ready for review January 31, 2026 07:04
Copilot AI review requested due to automatic review settings January 31, 2026 07:04
@hotlong hotlong merged commit 829cb97 into copilot/fix-issue-in-object-ui Jan 31, 2026
8 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses CI failures caused by Vitest exiting with code 1 when no test files are found. The solution adds passWithNoTests: true configuration to prevent test failures in packages that have test scripts but no actual tests yet.

Changes:

  • Added passWithNoTests: true to the root vitest.config.mts file
  • Added test sections with passWithNoTests: true to 17 package-level vite.config.ts files

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vitest.config.mts Added passWithNoTests: true to root test configuration
packages/components/vite.config.ts Added passWithNoTests: true to existing test section
packages/fields/vite.config.ts Added passWithNoTests: true to existing test section
packages/layout/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-aggrid/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-calendar/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-charts/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-chatbot/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-dashboard/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-editor/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-form/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-gantt/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-grid/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-kanban/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-map/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-markdown/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-timeline/vite.config.ts Created test section with passWithNoTests: true
packages/plugin-view/vite.config.ts Created test section with passWithNoTests: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants