Fix @typescript-eslint/ban-ts-comment violations#329
Merged
hotlong merged 3 commits intocopilot/enhance-console-functionsfrom Feb 2, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Replace @ts-ignore with @ts-expect-error in ObjectGrid.msw.test.tsx - Replace @ts-ignore with @ts-expect-error in ObjectTimeline.msw.test.tsx with proper description - Replace @ts-ignore with @ts-expect-error in ObjectForm.msw.test.tsx - Replace @ts-ignore with @ts-expect-error in app-generator.ts Fixes ESLint rule @typescript-eslint/ban-ts-comment violations Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Add descriptive explanation for @ts-expect-error directive Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update action steps for improved automation
Fix @typescript-eslint/ban-ts-comment violations
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates TypeScript suppression directives to satisfy ESLint rules and make intentional type mismatches explicit.
Changes:
- Replaced
@ts-ignorewith@ts-expect-errorin MSW-based tests for grid, form, and timeline plugins. - Replaced
@ts-ignorewith@ts-expect-errorin the CLI app generator’s generated layout template for dynamic Lucide icon lookup. - Added/updated inline explanations to clarify why the type suppression is intentional.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/plugin-timeline/src/ObjectTimeline.msw.test.tsx | Uses @ts-expect-error for intentionally mismatched mock schema in timeline MSW test. |
| packages/plugin-grid/src/ObjectGrid.msw.test.tsx | Uses @ts-expect-error in grid MSW test for the example-based import. |
| packages/plugin-form/src/ObjectForm.msw.test.tsx | Uses @ts-expect-error in form MSW test for the example-based import. |
| packages/cli/src/utils/app-generator.ts | Uses @ts-expect-error in generated code for dynamic Lucide icon lookup by string key. |
06fcaff
into
copilot/enhance-console-functions
10 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI lint was failing due to
@ts-ignoredirectives which ESLint now prohibits in favor of@ts-expect-error.Changes
Replaced all 4 instances of
@ts-ignorewith properly documented@ts-expect-error:@ts-expect-erroris safer as it errors if the suppression becomes unnecessary, while@ts-ignoresilently does nothing.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.