fix: sync ViewConfigPanel changes to all list view types in real-time#712
Merged
fix: sync ViewConfigPanel changes to all list view types in real-time#712
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…e preview) - Add showSort to objectViewSchema and its dependencies in Console ObjectView - Pass appearance/viewConfig properties (rowHeight, densityMode, color, etc.) through renderListView to fullSchema - Include striped/bordered from activeView in Plugin ObjectView gridSchema - Pass rowHeight, densityMode, groupBy in Plugin renderContent for renderListView path - Add showSort property to ObjectViewSchema interface and Zod schema - Respect showSort=false in Plugin sortSchema generation - Add 10 live preview sync tests across console and plugin-view Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
…ce spread Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix view config panel not syncing changes in all list types
fix: sync ViewConfigPanel changes to all list view types in real-time
Feb 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical UX issue where ViewConfigPanel edits (fields, filters, sort, appearance) were not reflected in real-time across all list view types (Grid/Kanban/Calendar/Timeline/Gallery/Map). Changes only appeared after clicking Save. The fix completes the live preview data flow by adding missing useMemo dependencies and propagating view configuration properties through the rendering chain.
Changes:
- Added
showSortproperty toObjectViewSchemainterface and Zod schema to control sort UI visibility - Extended useMemo dependency arrays in both console and plugin ObjectView components to track all view configuration properties
- Propagated appearance properties (
rowHeight,densityMode,striped,bordered, etc.) throughrenderListViewandgridSchemafor live preview - Added 10 new tests (4 console-level, 6 plugin-level) to verify live preview functionality across all scenarios
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/types/src/objectql.ts | Added showSort?: boolean property to ObjectViewSchema interface with JSDoc |
| packages/types/src/zod/objectql.zod.ts | Added showSort validation to ObjectViewSchema Zod schema |
| packages/plugin-view/src/ObjectView.tsx | Added showSort check in sortSchema, included striped/bordered in gridSchema, propagated rowHeight/densityMode/groupBy in renderListView, updated useMemo dependencies |
| apps/console/src/components/ObjectView.tsx | Added showSort to objectViewSchema with dependency, propagated appearance properties through fullSchema in renderListView |
| packages/plugin-view/src/tests/ObjectView.test.tsx | Added 6 live preview tests for prop updates (columns, sort, filters, appearance, renderListView, showSort) |
| apps/console/src/tests/ObjectView.test.tsx | Added 4 live preview tests for ViewConfigPanel sync (showSearch, showSort, columns, label) |
| ROADMAP.md | Updated test count to 5,110+ and documented the live preview feature completion |
27 tasks
30 tasks
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViewConfigPanel edits (fields, filters, sort, appearance) only reflected after clicking Save. The
useMemodependency chains from consoleObjectView→ pluginObjectView→ grid/list renderers had gaps that prevented live preview.Schema type
showSort?: booleantoObjectViewSchemainterface and Zod schemaConsole ObjectView
showSorttoobjectViewSchemauseMemo value and dependency arrayrowHeight,densityMode,inlineEdit,appearancefrom view draft throughrenderListView→fullSchemaPlugin ObjectView
showSort === falseinsortSchemagenerationstriped/borderedfromactiveViewingridSchemarowHeight,densityMode,groupByinrenderContent→renderListViewschemaTests
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.