-
Notifications
You must be signed in to change notification settings - Fork 2
fix: comprehensive view config panel cleanup — remove unused fields, correct view-type visibility for all controls #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0f064eb
Initial plan
Copilot c5aa70c
fix: add visibleWhen conditions to view config panel fields, remove r…
Copilot dd18955
test: update view-config-schema tests to match schema changes
Copilot 2382521
fix: remove tests for removed schema fields in ViewConfigPanel
Copilot 546332b
fix: comprehensive view config panel cleanup — remove unused fields, …
Copilot f43a480
fix: clarify clickIntoRecordDetails removal comment
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ROADMAP line 445 incorrectly states that rowActions/bulkActions support "grid/kanban" view types. Based on the runtime code investigation (packages/plugin-list/src/ListView.tsx lines 768-769), rowActions and bulkActions are only passed to the grid view schema, not to kanban or any other view type. The kanban plugin does not consume these properties.
This should be updated to:
This aligns with the critical bug identified in the view-config-schema.tsx predicates where supportsRowActions incorrectly includes 'kanban'.