Skip to content

Unit tests for jodd-vtor module to increase code coverage from 51% to 99% #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igr merged 4 commits into from
Jan 3, 2016
Merged

Unit tests for jodd-vtor module to increase code coverage from 51% to 99% #264

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91535f6
Add unit tests for jodd vtor module
cyburs Jan 3, 2016
7afb21f
Fixed a failing test “testUseProfiles_withTwoDifferentValues”
cyburs Jan 3, 2016
8b501b3
Merge branch 'df-unit-tests-vtor-UTS-226' of https://github.com/DevFa…
cyburs Jan 3, 2016
d9a2d0b
Fixed a failing test “testUseProfiles_withNullValue”
cyburs Jan 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions jodd-vtor/src/test/java/jodd/vtor/VtorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public void testUseProfile_withTwoDifferentValues() throws Exception {
Vtor vtor = new Vtor();
vtor.useProfile("testProfile");
assertEquals("size of list with profiles must be 1 when add one profile", vtor.enabledProfiles.size(), 1);
assertEquals("first element of enabled profiles must be testProfile when use testProfile", vtor.enabledProfiles.iterator().next(), "testProfile");
assertTrue("first element of enabled profiles must be testProfile when use testProfile", new ArrayList<String>(vtor.enabledProfiles).contains("testProfile"));

//when
vtor.useProfile(null);
Expand All @@ -128,20 +128,19 @@ public void testUseProfile_withTwoDifferentValues() throws Exception {
@Test
public void testUseProfiles_withNullValue() throws Exception {
Vtor vtor = new Vtor();
vtor.useProfiles((String) null);
vtor.useProfiles(null);
assertNull("list of enabled profiles must be null when add only null profile", vtor.enabledProfiles);
}

@Test
@Ignore
public void testUseProfiles_withTwoDifferentValues() throws Exception {
//given
Vtor vtor = new Vtor();
vtor.useProfiles("testProfile1", "testProfile2");
assertEquals("size of list with profiles must be 2 when add two profile", vtor.enabledProfiles.size(), 2);
Iterator<String> resultIterator = vtor.enabledProfiles.iterator();
assertEquals("first element must be equal to first added profile", resultIterator.next(), "testProfile1");
assertEquals("second element must be equal to second added profile", resultIterator.next(), "testProfile2");
ArrayList<String> enabledProfileList = new ArrayList<String>(vtor.enabledProfiles);
assertTrue("first element must be equal to first added profile", enabledProfileList.contains("testProfile1"));
assertTrue("second element must be equal to second added profile", enabledProfileList.contains("testProfile2"));

//when
vtor.useProfile(null);
Expand Down