feat: Requests and Events#37
feat: Requests and Events#37blorp-goes-the-derp merged 19 commits intoobs-websocket-community-projects:developfrom ChristopheCVB:feat/requests_and_events
Conversation
|
Thanks! Taking a look... |
blorp-goes-the-derp
left a comment
There was a problem hiding this comment.
I've reviewed the files and will try testing locally next...Only request so far was some more javadocs on one place, otherwise looks fantastic so far!
blorp-goes-the-derp
left a comment
There was a problem hiding this comment.
A bit more review, requesting some changes on one thing so far.
Otherwise testing was good, and I'll post a message to the original maintainers asking for their final feedback / if we can merge after the requested changes.
blorp-goes-the-derp
left a comment
There was a problem hiding this comment.
Looks great! I approve!
Still pending response from owners, I'll ping them and if there's no response in a few days then merge if that's fine with you.
Laraakaa
left a comment
There was a problem hiding this comment.
Thanks for this awesome extension! Looks good to me, we'll make sure to get this released once it's merged as new minor version!
Thanks for the kind words. |
|
I'm sorry guys, there were things that bothered me. I went ahead and refactored a bit. |
|
Ran the tests again, all seems well. |
I added some too and ran them locally before pushing each commit, including the OBSRemoteControllerUnsecuredIT |
a29b210
into
obs-websocket-community-projects:develop
Upgraded to Gradle 6.8.3
Upgraded Gson dependency to latest version
A bit of Cleanup
Added some Requests and Events
Refactor Events