fix: GetMute package#41
fix: GetMute package#41blorp-goes-the-derp merged 2 commits intoobs-websocket-community-projects:developfrom ChristopheCVB:fix/mute
Conversation
|
@TinaTiel Can you merge this please? |
|
I'll take a look later tonight. |
There was a problem hiding this comment.
Looks good, only suggestion I have is to update the test to capture the getMute callback correctness.
I've done this privately, but don't have permission to push to your remote -- so if you want to use this you're welcome to:
ObsRemoteE2eObservationIT.java
@Test
void setVolumeAndMute() {
obsShould("Set the volume to 50% (note, appears 67% due to log scaling; check % in advanced audio properties)");
remote.setSourceVisibility(null, "media", true, loggingCallback);
remote.setVolume(SOURCE_MEDIA, 0.50, loggingCallback);
obsShould("Mute the volume");
remote.setMute(SOURCE_MEDIA, true, loggingCallback);
remote.getMute(SOURCE_MEDIA, capturingCallback);
waitReasonably();
assertThat(getPreviousResponseAs(GetMuteResponse.class).isMuted()).isTrue();
obsShould("Unmute the volume");
remote.setMute(SOURCE_MEDIA, false, loggingCallback);
remote.getMute(SOURCE_MEDIA, capturingCallback);
waitReasonably();
assertThat(getPreviousResponseAs(GetMuteResponse.class).isMuted()).isFalse();
obsShould("Set the volume to 100%");
remote.setVolume(SOURCE_MEDIA, 1.00, loggingCallback);
}
Unrelated -- I'll create a separate branch to cleanup these tests a bit after we merge in yours; I think the waitReasonably() method should be part of getPreviousResponseAs(...) since it always needs to happen. Plus, there's your well-timed feedback on the other PR 🤣
blorp-goes-the-derp
left a comment
There was a problem hiding this comment.
Thanks! Great work
4dc94e1
into
obs-websocket-community-projects:develop
No description provided.