Skip to content

feat(install): Display detailed GPG verification failure information #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dylan-M merged 1 commit into from
Dec 22, 2025
Merged

feat(install): Display detailed GPG verification failure information #2999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion scripts/install/install_unix.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,27 @@ install_package()
dpkg -s "observiq-otel-collector" > /dev/null 2>&1 && dpkg --purge "observiq-otel-collector" > /dev/null 2>&1
fi

verify_package || error_exit "$LINENO" "Failed to verify package"
# Verify the package signature and display detailed error information on failure
# Capture GPG verification output to display failure details
# Temporarily disable set -e to allow capture of failing command output
set +e
gpg_verify_output=$(verify_package 2>&1)
gpg_verify_exit_code=$?
set -e

if [ $gpg_verify_exit_code -ne 0 ]; then
increase_indent
if [ -n "$gpg_verify_output" ]; then
printf "%s\n" "$gpg_verify_output"
fi
printf "\\n${indent}The package signature could not be verified. This may indicate:\n"
printf "${indent} - The GPG keys are not properly installed or accessible\n"
printf "${indent} - The package has been tampered with\n"
printf "${indent} - The signing key has expired or been revoked\n"
printf "${indent} - Network issues prevented GPG key retrieval\n"
decrease_indent
error_exit "$LINENO" "Failed to verify package"
fi
unpack_package || error_exit "$LINENO" "Failed to extract package"
succeeded

Expand Down
Loading