Skip to content

fix(bindplane_configuration) Platform does not need to force a new resource#118

Draft
jsirianni wants to merge 8 commits into
mainfrom
fix/platform-force-new
Draft

fix(bindplane_configuration) Platform does not need to force a new resource#118
jsirianni wants to merge 8 commits into
mainfrom
fix/platform-force-new

Conversation

@jsirianni
Copy link
Copy Markdown
Member

@jsirianni jsirianni commented Aug 13, 2024

Description of Changes

The provider tries to delete and re-create a config when changing the platform. Currently there are no constraints here, we can just apply over the existing config to change its platform.

Testing

Make sure you have Goreleaser v2 installed.

Log into https://app.bindplane.com and create an API key.

  1. Run make test-local to build the provider for local testing.
  2. cd test/local
  3. Update main.tf to use app.bindplane.com and an API key instead of basic auth.
provider "bindplane" {
  remote_url = "https://app.bindplane.com
  api_key = "YOUR API KEY"
}

Run terraform apply.

Edit main.tf and change the bindplane_configuration resource's platform from linux to windows. Re-run apply and observe that it changes the configuration instead of trying to delete and re-create.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

@jsirianni jsirianni force-pushed the fix/platform-force-new branch from b7cce35 to c61d316 Compare August 20, 2024 15:26
@jsirianni jsirianni changed the base branch from main to goreleaser-v2 August 20, 2024 15:26
@jsirianni jsirianni force-pushed the fix/platform-force-new branch from c61d316 to 89a7758 Compare August 20, 2024 15:48
@jsirianni jsirianni force-pushed the fix/platform-force-new branch from 89a7758 to 227b541 Compare August 20, 2024 15:54
@jsirianni jsirianni force-pushed the fix/platform-force-new branch from 227b541 to 0a5c41f Compare August 20, 2024 18:57
@jsirianni jsirianni marked this pull request as ready for review August 20, 2024 19:06
@jsirianni jsirianni requested a review from a team as a code owner August 20, 2024 19:06
@jsirianni jsirianni requested a review from algchoo August 20, 2024 19:06
Base automatically changed from goreleaser-v2 to main August 28, 2024 14:32
@jsirianni jsirianni removed the request for review from algchoo March 5, 2025 14:33
@jsirianni jsirianni marked this pull request as draft March 5, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant