fix(bindplane_configuration) Platform does not need to force a new resource#118
Draft
jsirianni wants to merge 8 commits into
Draft
fix(bindplane_configuration) Platform does not need to force a new resource#118jsirianni wants to merge 8 commits into
jsirianni wants to merge 8 commits into
Conversation
b7cce35 to
c61d316
Compare
c61d316 to
89a7758
Compare
89a7758 to
227b541
Compare
227b541 to
0a5c41f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The provider tries to delete and re-create a config when changing the platform. Currently there are no constraints here, we can just apply over the existing config to change its platform.
Testing
Make sure you have Goreleaser v2 installed.
Log into https://app.bindplane.com and create an API key.
make test-localto build the provider for local testing.cd test/localmain.tfto use app.bindplane.com and an API key instead of basic auth.Run
terraform apply.Edit
main.tfand change thebindplane_configurationresource's platform fromlinuxtowindows. Re-runapplyand observe that it changes the configuration instead of trying to delete and re-create.Please check that the PR fulfills these requirements