Skip to content

feature: allow specifying which shell to use for cram test #8134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haochenx wants to merge 33 commits into from
Closed

feature: allow specifying which shell to use for cram test #8134

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
80a5248
cram_exec - add shell_spec to action spec
haochenx Jul 6, 2023
506ff24
cram - add (shell ..) option to the (cram) stanza
haochenx Jul 6, 2023
7273d46
cram - shell-opt.t - add one test case
haochenx Jul 6, 2023
8d34734
fix tests: test/blackbox-tests/test-cases/cram/shell-opt.t
haochenx Jul 6, 2023
5850f0c
add test/blackbox-tests/test-cases/cram/shell-opt-zsh.t
haochenx Jul 6, 2023
96e8204
make fmt
haochenx Jul 6, 2023
60de1af
move Cram_stanza.shell_spec to Dune_lang.Shell_spec.t
haochenx Jul 7, 2023
c5724de
cram - add (shell ..) option to the (cram) user action
haochenx Jul 7, 2023
6aa7773
restrict (shell ..) option on (cram ..) to (lang dune 3.10) or later
haochenx Jul 7, 2023
dae85d8
cram - small fix of document
haochenx Jul 7, 2023
6b8218a
cram - add document describing (shell ..) option
haochenx Jul 7, 2023
d05b7c0
Merge branch 'main' into cram-shell-spec
haochenx Jul 7, 2023
3350047
add change log entry for #8134
haochenx Jul 7, 2023
2a23c30
address review comments: CHANGES
haochenx Jul 8, 2023
716b5fc
address review comments: Dune_lang.Action.Cram arg: record => tuple
haochenx Jul 8, 2023
f3abb2f
address review comments: Dune_lang.Shell_spec: +map and some comments
haochenx Jul 8, 2023
e557e4f
address review comments: format cram-action-shell-opt.t
haochenx Jul 8, 2023
1669115
address review comments: fix encoder bug in dune_lang/action.ml
haochenx Jul 8, 2023
071f56c
address review comments: replace Cram_exec.Shell_spec.t with Path.t
haochenx Jul 8, 2023
2363502
attempt fix bug
haochenx Jul 8, 2023
1721f66
Apply suggestions from code review - doc wording
haochenx Jul 11, 2023
5dfe145
Merge branch 'main' into cram-shell-spec
haochenx Jul 11, 2023
78a5ab8
Merge branch 'main' into cram-shell-spec
haochenx Jul 11, 2023
e291312
Merge branch 'main' into cram-shell-spec
haochenx Jul 11, 2023
c686868
Merge remote-tracking branch 'up/main' into cram-shell-spec
haochenx Sep 25, 2023
fbc7b4f
reflect review comments
haochenx Sep 25, 2023
9dbb040
fix CHANGES.md
haochenx Sep 25, 2023
25c1cc0
bump to 3.12
haochenx Sep 25, 2023
c3a06f5
correct dune language version
haochenx Sep 25, 2023
1993b95
fix tests and doc
haochenx Sep 25, 2023
544d9f2
no optional encoded action
haochenx Sep 25, 2023
5a8f2de
fix hint text in Cram_stanza.system_shell_prog
haochenx Sep 25, 2023
35fb63d
remove extra space
christinerose Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add change log entry for #8134 
Signed-off-by: Haochen Kotoi-Xie <hx@kxc.inc>
  • Loading branch information
@haochenx
haochenx committed Jul 7, 2023
commit 33500476ee6659ef1a1b3cc8404ccc8fe39e081d
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ Unreleased
- Add `dune build --dump-gc-stats FILE` argument to dump Garbage Collection
stats to a named file. (#8072, @Alizter)

- Add `(shell ..)` option to cram test stanza and user action specification.
(#8134, @haochenx)

3.9.0 (2023-06-28)
------------------

Expand Down