fix(ocamllsp): workspace symbols fallback to _build folder#1097
Open
tatchi wants to merge 2 commits intoocaml:masterfrom
Open
fix(ocamllsp): workspace symbols fallback to _build folder#1097tatchi wants to merge 2 commits intoocaml:masterfrom
tatchi wants to merge 2 commits intoocaml:masterfrom
Conversation
tatchi
commented
May 16, 2023
| let sourcefile = Filename.concat root_uri fname in | ||
| let path = | ||
| if Fpath.exists (Fpath.of_string sourcefile) then sourcefile | ||
| else build_dir ^ "/" ^ fname |
Collaborator
Author
There was a problem hiding this comment.
We should probably also verify that the uri in _build folder exist? And if not remove the entry ?
Pull Request Test Coverage Report for Build 3735Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
3Rafal
reviewed
May 18, 2023
| let sourcefile = Filename.concat root_uri fname in | ||
| let path = | ||
| if Fpath.exists (Fpath.of_string sourcefile) then sourcefile | ||
| else build_dir ^ "/" ^ fname |
Collaborator
There was a problem hiding this comment.
I think it would be better if we use Fpath for path concatenation, instead of doing it by hand
Collaborator
|
Pls add a changelog note |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It checks that the
uriexist and otherwise fallback to the_buildfolder. This might be the case for generated files (that only exist in the_buildfolder.Before:
Screen.Recording.2023-05-16.at.07.10.12.mov
After:
Screen.Recording.2023-05-16.at.07.09.33.mov