Add upper bound on stdune 3.22#29561
Merged
shonfeder merged 1 commit intoocaml:masterfrom Mar 19, 2026
Merged
Conversation
Required by a breaking API change in stdune
This was referenced Mar 19, 2026
Member
Author
|
Given that this is just an upper bounds addition and that the majority of CI results are already in, I am going to save the compute and merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by a breaking API change in stdune
Discovered in #29547 (comment)
@Alizter helped diagnose the root cause, which was a breaking API change in Stdune introduced in ocaml/dune#13430, and explained at ocaml/dune#13674 (comment) .
We discussed this in the dun-dev meeting with @rgrinberg today.