Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/alipay/oceanbase/hbase/OHTable.java
Original file line number Diff line number Diff line change
Expand Up @@ -1927,6 +1927,7 @@ private ObTableQuery buildObTableQuery(ObHTableFilter filter, byte[] start,
obTableQuery.setIndexName("PRIMARY");
obTableQuery.sethTableFilter(filter);
obTableQuery.addKeyRange(obNewRange);
obTableQuery.setScanRangeColumns("K", "Q", "T");
return obTableQuery;
}

Expand All @@ -1953,6 +1954,7 @@ private ObTableQuery buildObTableQuery(ObHTableFilter filter, final Scan scan) {
: configuration.getLong(HConstants.HBASE_CLIENT_SCANNER_MAX_RESULT_SIZE_KEY,
HConstants.DEFAULT_HBASE_CLIENT_SCANNER_MAX_RESULT_SIZE));
obTableQuery.setObKVParams(buildOBKVParams(scan));
obTableQuery.setScanRangeColumns("K", "Q", "T");
return obTableQuery;
}

Expand All @@ -1978,6 +1980,7 @@ private ObTableQuery buildObTableQuery(final Get get, Collection<byte[]> columnQ
get.getTimeRange());
}
obTableQuery.setObKVParams(buildOBKVParams(get));
obTableQuery.setScanRangeColumns("K", "Q", "T");
return obTableQuery;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -226,17 +226,11 @@ public static void testScanImpl(String tableName) throws Exception {
Scan scan = new Scan(keys[1].getBytes(), "putKey".getBytes());
scan.addFamily(family.getBytes());
scan.setReversed(true);
ResultScanner scanner = hTable.getScanner(scan);
List<Cell> cells = getCellsFromScanner(scanner);

int cellIndex = 0;
for (int i = 1; i >= 0; i--) {
for (String column : columns) {
AssertKeyValue(keys[i], column, lastTs, latestValue, cells.get(cellIndex));
cellIndex++;
}
try {
hTable.getScanner(scan);
} catch (Exception e) {
Assert.assertTrue(e.getCause().getMessage().contains("secondary partitioned hbase table with reverse query not supported"));
}
assertEquals(columns.length * 2, cells.size());
}
hTable.close();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ public static void testScanImpl(String tableName) throws Exception {
// 4. scan using setStartRow/setEndRow
{
Scan scan = new Scan();
scan.addFamily(family.getBytes());
scan.setStartRow(keys[0].getBytes());
scan.setStopRow(endKey.getBytes());
ResultScanner scanner = hTable.getScanner(scan);
Expand All @@ -173,15 +174,13 @@ public static void testScanImpl(String tableName) throws Exception {
Scan scan = new Scan(keys[0].getBytes(), endKey.getBytes());
scan.addFamily(family.getBytes());
scan.setBatch(batchSize);
ResultScanner scanner = hTable.getScanner(scan);
Result result = null;
int resultSize = (keys.length * columns.length * values.length) / batchSize;
for (int i = 0; i < resultSize; i++) {
result = scanner.next();
Assert.assertEquals(2, result.size());
try {
ResultScanner scanner = hTable.getScanner(scan);
} catch (Exception e) {
Assert.assertTrue(e.getCause().getMessage()
.contains("timeseries hbase table with batch query not supported"));
}
result = scanner.next();
Assert.assertEquals(null, result);

}

// 7. scan using setAllowPartialResults/setAllowPartialResults
Expand All @@ -190,32 +189,25 @@ public static void testScanImpl(String tableName) throws Exception {
scan.addFamily(family.getBytes());
scan.setMaxResultSize(10);
scan.setAllowPartialResults(true);
ResultScanner scanner = hTable.getScanner(scan);
int resultSize = keys.length * columns.length * values.length;
for (int i = 0; i < resultSize; i++) {
Result result = scanner.next();
Assert.assertEquals(1, result.size());
try {
ResultScanner scanner = hTable.getScanner(scan);
} catch (Exception e) {
Assert.assertTrue(e.getCause().getMessage()
.contains("timeseries hbase table with allow partial results query not supported"));
}
Result result = scanner.next();
Assert.assertEquals(null, result);
}

// 8. scan in reverse
{
// Scan scan = new Scan(keys[2].getBytes(), keys[0].getBytes());
// scan.addFamily(family.getBytes());
// scan.setReversed(true);
// ResultScanner scanner = hTable.getScanner(scan);
// List<Cell> cells = getCellsFromScanner(scanner);
//
// int cellIndex = 0;
// for (int i = 1; i >= 0; i--) {
// for (String column : columns) {
// AssertKeyValue(keys[i], column, lastTs, latestValue, cells.get(cellIndex));
// cellIndex++;
// }
// }
// assertEquals(columns.length * 2, cells.size());
Scan scan = new Scan(keys[2].getBytes(), keys[0].getBytes());
scan.addFamily(family.getBytes());
scan.setReversed(true);
try {
ResultScanner scanner = hTable.getScanner(scan);
} catch (Exception e) {
Assert.assertTrue(e.getCause().getMessage()
.contains("timeseries hbase table with reverse query not supported"));
}
}
}

Expand Down