feat(fts): support ANALYZER parser with PARSER_PROPERTIES#65
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for OceanBase full-text ANALYZER parser configuration by carrying PARSER_PROPERTIES through the SDK and emitting it in the generated CREATE FULLTEXT INDEX DDL, plus adding a helper to construct analyzer properties and tests for compilation/validation.
Changes:
- Extend
FtsIndexParamandFtsIndexto carryparser_properties, and appendPARSER_PROPERTIES = (...)during FTS index DDL compilation. - Add
FtsParser.ANALYZERsupport, including amake_analyzer_properties()helper and validation when using the enum value. - Update client index creation paths to pass
parser_properties, and add unit tests for SQL compilation and validation behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_fts_index.py | Adds unit tests covering ANALYZER behavior, parser_properties propagation, and DDL compilation. |
| pyobvector/schema/full_text_index.py | Extends FtsIndex to accept parser_properties and appends PARSER_PROPERTIES to generated DDL. |
| pyobvector/client/ob_vec_client.py | Passes parser_properties from FtsIndexParam into FtsIndex when creating indexes. |
| pyobvector/client/fts_index_param.py | Adds ANALYZER parser type, parser_properties support, and helper for analyzer properties. |
| pyobvector/client/init.py | Re-exports make_analyzer_properties from the client package. |
| pyobvector/init.py | Re-exports make_analyzer_properties at top-level package API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
240607c to
6ff0428
Compare
Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
…rser_type and FtsIndex Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
6ff0428 to
9495c6f
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.