fix(reflection): parse OceanBase FTS_INDEX_TYPE in SHOW CREATE TABLE#68
Merged
Conversation
fix: - Allow optional spaces around `=` for PARSER_PROPERTIES (align with BLOCK_SIZE style) - Parse FTS_INDEX_TYPE clause to avoid SAWarning on unknown schema content during reflect Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Improves OceanBase DDL reflection by expanding the table-definition key regex to recognize additional FULLTEXT index options, preventing reflection-time “Unknown schema content” warnings for analyzer-based fulltext indexes.
Changes:
- Loosened
PARSER_PROPERTIESmatching to allow optional spaces around=. - Added parsing support for
FTS_INDEX_TYPE(e.g.,MATCH,PHRASE_MATCH) in key definitions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…PERTIES test: - Add regression for FULLTEXT KEY with PARSER_PROPERTIES = (...) and FTS_INDEX_TYPE = PHRASE_MATCH Co-authored-by: Cursor <cursoragent@cursor.com>
test: - Build FULLTEXT KEY line via concatenation to stay within pylint line limits - Use readable parser_properties JSON instead of nested escapes in SQL literal Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OceanBaseTableDefinitionParser._re_keyto recognizePARSER_PROPERTIESwith optional spaces around=(same pattern asBLOCK_SIZE).FTS_INDEX_TYPE(MATCH/PHRASE_MATCH) sometadata.reflect()no longer emitsSAWarning: Unknown schema contentfor OceanBase fulltext indexes using the analyzer parser.Context
When tables include DDL such as:
reflection previously failed to match the index line and logged a warning. Functionality was unaffected; this only improves schema reflection compatibility.
Test plan
python3 -m unittest tests.test_reflection -vUnknown schema contentwarningsMade with Cursor