Add IRC bridging + other production stuff#7
Conversation
631da18 to
bbc38f5
Compare
|
So I've made some changes for the sake of testing it on app-matrix, which included changing the original Docker image versions to personal builds. There's a lot of cleanup to be done on this branch before I'm happy with getting it merged, which I'm outlining here:
|
|
Yeet. |
cg505
left a comment
There was a problem hiding this comment.
👌👀👌👀👌👀👌👀👌👀 good shit go౦ԁ sHit👌 thats ✔ some good👌👌shit right👌👌there👌👌👌 right✔there ✔✔if i do ƽaү so my self 💯 i say so 💯 thats what im talking about right there right there (chorus: ʳᶦᵍʰᵗ ᵗʰᵉʳᵉ) mMMMMᎷМ💯 👌👌 👌НO0ОଠOOOOOОଠଠOoooᵒᵒᵒᵒᵒᵒᵒᵒᵒ👌 👌👌 👌 💯 👌 👀 👀 👀 👌👌Good shit
Take a look at how ocfweb does this stuff. For instance, it just builds all the images with the same tag: https://github.com/ocf/ocfweb/blob/d7d22d7ee88ce0599f69ea3d93f7de7749fd814f/Makefile#L36-L38 (
See inline comments. |
65371e6 to
df8bb2a
Compare
19bc838 to
1e80bc2
Compare
cg505
left a comment
There was a problem hiding this comment.
if our entire dockerfile is literally just FROM ..., we shouldn't build a docker image at all. we can just use the upstream docker image directly in the kubernetes yaml.
I think it makes it more consistent that they are built here, and since Matrix as a whole is an evolving standard, we might need to do some patching to the images in case of breaking changes, etc. It's also nice to be able to see and update image versions from one file |
it feels weird, but I guess that makes sense |
Dockerfile.bridge -> ENTRYPOINT to CMD for more flexibility with the image later. Dockerfile.matrix -> Synapse log config has been patched into the image itself.
Latest commit patches both Dockerfiles, ~20 minutes after the latest comment |
Co-authored-by: Nikhil Jha <njha@ocf.berkeley.edu>
| containers: | ||
| - name: matrix-synapse | ||
| image: "docker.ocf.berkeley.edu/synapse:<%= version %>" | ||
| imagePullPolicy: Always |
This is so that the Matrix server can bridge properly. The bridge itself has not been placed inside the Kubernetes deployment yet, though the configuration files are there. Fixes #4 and #2 + more.
Also incorporates secret templating, Postgres integration, etc.