print form website#899
Conversation
BNH440
left a comment
BNH440
left a comment
There was a problem hiding this comment.
overall I think this is unnecessary, it looks to me like the print queue gets pretty backed up during peak times, I think this would just make things worse
|
|
||
| ALL_PRINTERS = ('papercut', 'pagefault', 'logjam', 'logjam-old', 'deforestation') | ||
| ACTIVE_PRINTERS = ('papercut', 'pagefault', 'logjam') | ||
| ALL_PRINTERS = ('papercut', 'pagefault', 'logjam', 'logjam-old', 'deforestation', 'OCF-BW', 'OCF-Color') |
There was a problem hiding this comment.
please don't use the aggregate names here, these variables are referenced elsewhere in ocfweb
There was a problem hiding this comment.
see my stats branch for the proper way to do this, although it's far from finished https://github.com/ocf/ocfweb/tree/printer-stats-update
| { | ||
| 'title': 'Printing Statistics', | ||
| 'current_printers': PRINTERS, | ||
| 'current_printers': get_printers().keys(), |
There was a problem hiding this comment.
why did you update the variables above and then not use them
There was a problem hiding this comment.
why did the devenv get updated as a side effect to this pr
| db = ocfstats | ||
|
|
||
| [printing] | ||
| # Joe's VM |
There was a problem hiding this comment.
using joe's staff vm is not acceptable for deployment, also there's probably better ways to do this
4 participants
Print from website under account
Use 6 digit otp from joes vm to make sure people are in the ocf