Add mem.buffer_from_slice_panicking proc#6030
Open
Xotchkass wants to merge 1 commit intoodin-lang:masterfrom
Open
Add mem.buffer_from_slice_panicking proc#6030Xotchkass wants to merge 1 commit intoodin-lang:masterfrom
mem.buffer_from_slice_panicking proc#6030Xotchkass wants to merge 1 commit intoodin-lang:masterfrom
Conversation
Member
|
Just make a new procedure instead of modifying an established one. |
Xotchkass
force-pushed
the
panic_on_grow
branch
from
0e16cfe to
f742429
Compare
Xotchkass
changed the title
panic_on_grow parameter to mem.buffer_from_slicemem.buffer_from_slice_panicking proc
Contributor
Author
|
Ok |
Xotchkass
force-pushed
the
panic_on_grow
branch
from
f742429 to
0e9aec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panicking on appending to a full buffer can often help to catch logical errors early. I set the parameter to
falseby default, so it wouldn't cause issues in existing code. I believe there shouldn't be any downsides to having it.