Remove unreachable branch in filename_from_path#6480
Open
cuiweixie wants to merge 1 commit intoodin-lang:masterfrom
Open
Remove unreachable branch in filename_from_path#6480cuiweixie wants to merge 1 commit intoodin-lang:masterfrom
cuiweixie wants to merge 1 commit intoodin-lang:masterfrom
Conversation
After handling string_extension_position >= 0, i is negative, so the following i > 0 block was never executed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
filename_from_path, theif (i > 0)block after thei >= 0early return can never run: when control reaches it,string_extension_positionreturned a negative value, soi > 0is always false. Remove the dead code; behavior is unchanged.