[IMP] sales: pricelist forumla usecase fix - #19274
Closed
meval1006 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
meval1006
force-pushed
the
saas-19.4-rental-pricelists-fix-meval
branch
from
August 4, 2026 19:45
a526b35 to
3628254
Compare
meval1006
marked this pull request as ready for review
August 4, 2026 19:45
meval1006
force-pushed
the
saas-19.4-rental-pricelists-fix-meval
branch
from
August 4, 2026 20:47
3628254 to
30b2da4
Compare
meval1006
changed the title
Contributor
Author
|
Hi @erjer-odoo, this PR is ready for review |
erjer-odoo
approved these changes
Aug 5, 2026
erjer-odoo
left a comment
erjer-odoo
left a comment
Contributor
There was a problem hiding this comment.
Mostly fine -- just a few fixes I'd like you to make. Before you merge, please run make fast and make sure the relative paths for doc links resolve correctly...or wait until all checks pass before you actually merge. I want to be sure they work correctly.
Otherwise, LGTM.
@robodoo delegate+
Co-authored-by: Erin J <erjer@odoo.com>
meval1006
force-pushed
the
saas-19.4-rental-pricelists-fix-meval
branch
from
August 5, 2026 18:29
ad4d4cd to
309a1dd
Compare
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Aug 5, 2026
closes #19274 Signed-off-by: Megan Valenzuela (meval) <meval@odoo.com> Co-authored-by: Erin J <erjer@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Aug 5, 2026
closes #19274 Signed-off-by: Megan Valenzuela (meval) <meval@odoo.com> Co-authored-by: Erin J <erjer@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does and why it's needed
Corrects the dynamic pricing example in the pricelist formula documentation. A SME clarified the correct terminology and formula configuration for calculating margin on the cost of a product, so the "Classic Brown Jacket" example was updated to reflect a 10% markup on cost instead of the previous, incorrect 100% markup with a $5 minimum margin.
This
saas-19.4PR can be FWP up tomaster.