Add support to provide middle ware options to express router#137
Merged
seanadkinson merged 1 commit intoAug 17, 2017
Merged
Conversation
…ing related routes
Contributor
|
Looks good, thank you! |
Contributor
|
Pushed v4.3.0 with this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's quite common for developers to want to protect their routes (especially if those routes interact with server resources like s3 buckets) with middle ware.
I love the library, but while trying to use it in a project it was not feasible out of the box as I could not use auth protected routes, rate limiting etc.
This PR allows a user to provide middle ware options to be used by the express routes.
This is my first PR in this repo so apologies if I missed any styling guidelines.