Skip to content

inputRef should support React.createRef #176#200

Merged
seanadkinson merged 1 commit into
odysseyscience:masterfrom
mihaimartalogu:master
Nov 4, 2020
Merged

inputRef should support React.createRef #176#200
seanadkinson merged 1 commit into
odysseyscience:masterfrom
mihaimartalogu:master

Conversation

@mihaimartalogu

Copy link
Copy Markdown
Contributor

For cases when custom components reference ReactS3Uploader's input through a React.createRef(), for example:

  const uploaderInputRef = React.createRef();
  ...
      <ReactS3Uploader
        ...
        inputRef={uploaderInputRef}
      />
      <button onClick={() => { uploaderInputRef.current.click(); }}>upload file</button>

@rootux

rootux commented Nov 4, 2020

Copy link
Copy Markdown

Looks good. @odysseyscience please merge.

@seanadkinson seanadkinson merged commit ff620e6 into odysseyscience:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants