Skip to content

[CHORE] Update Argument Types#211

Merged
seanadkinson merged 1 commit into
odysseyscience:masterfrom
jarretmoses:chore-more-explicit-onfinish-types
Jan 22, 2020
Merged

[CHORE] Update Argument Types#211
seanadkinson merged 1 commit into
odysseyscience:masterfrom
jarretmoses:chore-more-explicit-onfinish-types

Conversation

@jarretmoses

@jarretmoses jarretmoses commented Jan 22, 2020

Copy link
Copy Markdown
Contributor

Addresses more explicit response type as well as adds a missing argument or type File that also gets passed in.

@jarretmoses jarretmoses force-pushed the chore-more-explicit-onfinish-types branch from 34ff67e to 4c29835 Compare January 22, 2020 03:10
@jarretmoses jarretmoses changed the title [CHORE] Update onFinish Argument Types [CHORE] Update Argument Types Jan 22, 2020
@jarretmoses jarretmoses force-pushed the chore-more-explicit-onfinish-types branch from 4c29835 to de05934 Compare January 22, 2020 03:11
@seanadkinson

Copy link
Copy Markdown
Contributor

👍

@seanadkinson seanadkinson merged commit 47ff275 into odysseyscience:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants