Skip to content

TypeScript tweaks and fixes#212

Merged
seanadkinson merged 2 commits into
odysseyscience:masterfrom
dobesv:ts-fixup
Nov 4, 2020
Merged

TypeScript tweaks and fixes#212
seanadkinson merged 2 commits into
odysseyscience:masterfrom
dobesv:ts-fixup

Conversation

@dobesv

@dobesv dobesv commented Jan 30, 2020

Copy link
Copy Markdown
Contributor
  • fix: React was used but not imported
  • fix: S3Upload extends onFinishS3Put rather than onFinish
  • tweak: Add typescript & types/react dev dependencies
  • tweak: Explicitly set "types" in package.json
  • upload S3Upload options declared to match the ones actually used

@dobesv dobesv force-pushed the ts-fixup branch 4 times, most recently from ac3ff54 to b7bedf4 Compare January 30, 2020 19:11
- fix: React was used but not imported
- fix: S3Upload extends onFinishS3Put rather than onFinish
- tweak: Add typescript & types/react dev dependencies
- tweak: Explicitly set "types" in package.json
@seanadkinson seanadkinson merged commit 7bf1a65 into odysseyscience:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants