Skip to content

Add Missing Props and Methods to index.d.ts#216

Merged
seanadkinson merged 2 commits into
odysseyscience:masterfrom
mrjones2014:master
May 19, 2020
Merged

Add Missing Props and Methods to index.d.ts#216
seanadkinson merged 2 commits into
odysseyscience:masterfrom
mrjones2014:master

Conversation

@mrjones2014

Copy link
Copy Markdown
Contributor

index.d.ts was missing one of the props for the component, and missing the uploadFile method from the S3Upload class.

add missing methods and props to index.d.ts
@mrjones2014

Copy link
Copy Markdown
Contributor Author

@seanadkinson have you looked at this PR yet? it's very small, just a TS definitions change.

@seanadkinson

Copy link
Copy Markdown
Contributor

@mrjones2014 Thanks, sorry for the delay... will merge

@seanadkinson seanadkinson merged commit ecdb250 into odysseyscience:master May 19, 2020
@mrjones2014

Copy link
Copy Markdown
Contributor Author

@seanadkinson awesome! thanks! this upgrade will allow me to remove a // @ts-ignore comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants