Open
Conversation
sielicki
force-pushed
the
add-nix-support
branch
from
1c4ff30 to
d005804
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive Nix flake support to libfabric, enabling reproducible builds, development environments, and CI workflows. The implementation provides a modern development and build infrastructure using Nix with support for multiple platforms and cross-compilation.
Key changes:
- Adds Nix flake configuration with development shells for all providers and HMEM types
- Implements cross-compilation support from Darwin to Linux targets (aarch64 and x86_64)
- Adds GitHub Actions CI workflow for automated building and testing using Nix
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| flake.nix | Main flake configuration defining packages, development shells, and cross-compilation targets |
| flake.lock | Lock file pinning specific versions of flake dependencies |
| contrib/nix/lib/default.nix | Reusable library functions for packaging and cross-compilation |
| contrib/nix/pkgs/libfabric/default.nix | Nix package definition for libfabric with configurable providers and HMEM support |
| contrib/nix/pkgs/libcxi/default.nix | Package definition for libcxi (HPE Cassini/Slingshot library) |
| contrib/nix/pkgs/xpmem/default.nix | Package definition for XPMEM userspace library |
| contrib/nix/pkgs/cassini-headers/default.nix | Package definition for HPE Cassini hardware headers |
| contrib/nix/pkgs/cxi-driver-headers/default.nix | Package definition for CXI driver UAPI headers |
| contrib/nix/pkgs/accel-config/default.nix | Package definition for Intel DSA/IAA accelerator configuration utility |
| .github/workflows/nix.yml | GitHub Actions workflow for building and testing with Nix |
| .gitignore | Adds Nix-specific ignore patterns for build artifacts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Nicholas Sielicki <opensource@nslick.com>
sielicki
force-pushed
the
add-nix-support
branch
from
d005804 to
cde55b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a nix flake for development shells and ci, with the goal of:
see https://nixos.org/ for details on nix