Suggested updates to proof of concept C host documentation#1
Conversation
| && rm wasi-sdk-${WASI_SDK_VERSION}.0-x86_64-linux.deb | ||
| RUN set -eux; \ | ||
| case "${TARGETARCH}" in \ | ||
| amd64) WASI_SDK_ARCH=amd64 ;; \ |
There was a problem hiding this comment.
| amd64) WASI_SDK_ARCH=amd64 ;; \ | |
| amd64) WASI_SDK_ARCH=x86_64 ;; \ |
got a 404 for https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-27/wasi-sdk-27.0-amd64-linux.deb trying to run this on x86
0.435 Errors were encountered while processing:
0.435 wasi-sdk-27.0-amd64-linux.deb
------
Dockerfile.guest_and_host:23
--------------------
22 | # Install wasi-sdk (for building the guest component)
23 | >>> RUN set -eux; \
24 | >>> case "${TARGETARCH}" in \
25 | >>> amd64) WASI_SDK_ARCH=amd64 ;; \
26 | >>> arm64) WASI_SDK_ARCH=arm64 ;; \
27 | >>> *) echo "Unsupported TARGETARCH: ${TARGETARCH}" >&2; exit 1 ;; \
28 | >>> esac; \
29 | >>> curl -sLO "https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-${WASI_SDK_VERSION}/wasi-sdk-${WASI_SDK_VERSION}.0-${WASI_SDK_ARCH}-linux.deb"; \
30 | >>> dpkg -i "wasi-sdk-${WASI_SDK_VERSION}.0-${WASI_SDK_ARCH}-linux.deb"; \
31 | >>> rm "wasi-sdk-${WASI_SDK_VERSION}.0-${WASI_SDK_ARCH}-linux.deb"
32 |
--------------------
There was a problem hiding this comment.
Though this is the guest one so if rebasing onto bytecodealliance:main and grabbing that adder.wasm works, this file can just go away
| 1 + 2 = 3 | ||
| ``` | ||
|
|
||
| *TODO: work in `wasmtime --invoke 'add(2,2)' adder.wasm`* |
There was a problem hiding this comment.
We don't want wasmtime --invoke as Option C?
| . | ||
| ``` | ||
|
|
||
| *TODO: the C++ API is nicer and may be more appropriate for example code* |
There was a problem hiding this comment.
Also seems fine to remove if it'd be annoying
|
@ohAitch do you mind pushing any suggestions as changes to this/ overwriting anything that you disagree with? |
|
Yeah legit we're getting into patches on patches on patches, I'll take a more hands-on look |
- Fills in documentation on how to use the C host - Updates Dockerfile to be cross architecture - Adds a new Dockerfile that is just the host Signed-off-by: Kate Goldenring <kgoldenr@akamai.com>
kate-goldenring
force-pushed
the
c-docs-updates
branch
from
7e3d551 to
6928e63
Compare
Signed-off-by: Kate Goldenring <kgoldenr@akamai.com>
|
@ohAitch I added in a couple of your requested changes. I think it is mainly the rebasing that needs to be taken care of |
2 participants
Done with the help of Copilot with Sonnet 4.6