Don't die if you can't reach a single Rancher server.#28
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a lightweight reachability probe before validating each configured Rancher server, so that a single unreachable Rancher no longer aborts the entire adp-connect.sh flow. When curl to https://${SERVER}/ping fails with a "host unreachable"-style exit code, the script now warns and skips that server instead of letting rancher project list hang or error out.
Changes:
- Probe each Rancher server with
curl -s --max-time 10 .../pinginside the validation loop. - Treat curl exit codes 6 (DNS) and 7 (connect) as unreachable, emit a warning, and
continueto the next server.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
deadwanderer
previously approved these changes
May 14, 2026
phinphan20
previously approved these changes
May 14, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
phinphan20
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.