Skip to content

Conversation

@oising
Copy link
Owner

@oising oising commented Jun 10, 2025

  • add spiralog sample cli
  • add endpoint to signalr hub for remote log streaming

Copilot AI review requested due to automatic review settings June 10, 2025 16:26
@oising oising self-assigned this Jun 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements remote log viewing by introducing a sample CLI application (SpiraLog) and extending the SignalR hub to stream logs in real time. Key changes include:

  • Upgrading several package versions and updating project configurations.
  • Updating the hub resource to use a typed ResourceLoggerService and adding model injection.
  • Adding a new sample console application (SpiraLog) for demonstrating remote log streaming.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Src/Nivot.Aspire.ProjectCommander/Nivot.Aspire.ProjectCommander.csproj Updated package versions to support the new log streaming functionality
Src/Nivot.Aspire.Hosting.ProjectCommander/ProjectCommanderHubResource.cs Modified to inject ResourceLoggerService and DistributedApplicationModel instead of a generic logger
Src/Nivot.Aspire.Hosting.ProjectCommander/ProjectCommanderHubLifecycleHook.cs Adjusted logger setup and added model injection to align with hub resource changes
Src/Nivot.Aspire.Hosting.ProjectCommander/ProjectCommanderHub.cs Updated hub constructor to include new dependencies and added a new log streaming method
Directory.Build.props & various Sample projects Updated package versions and added new sample CLI project (SpiraLog) along with corresponding configuration changes
ProjectCommander.sln & ProjectCommander.Tests Incorporated SpiraLog into the solution and upgraded test dependencies
Comments suppressed due to low confidence (1)

Src/Nivot.Aspire.Hosting.ProjectCommander/ProjectCommanderHub.cs:23

  • The static ToTuple method is declared but never used; please remove it to reduce unnecessary code and improve clarity.
static (int LineNumber, string Content, bool IsErrorMessage) ToTuple(LogLine logLine) => (logLine.LineNumber, logLine.Content, logLine.IsErrorMessage);

@oising oising merged commit 3e3000d into main Jun 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants