Skip to content

fix: docker file for umee price feeder to be used in umee e2e test#55

Merged
rbajollari merged 3 commits intoumeefrom
ryan/docker-build-fix
Mar 16, 2023
Merged

fix: docker file for umee price feeder to be used in umee e2e test#55
rbajollari merged 3 commits intoumeefrom
ryan/docker-build-fix

Conversation

@rbajollari
Copy link
Member

Description


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zarazan
Copy link
Contributor

zarazan commented Mar 14, 2023

Why does the price-feeder need cosmwasm installed?

@rbajollari
Copy link
Member Author

Why does the price-feeder need cosmwasm installed?

Its only for the umee version since its a dependency for importing umee

@rbajollari rbajollari marked this pull request as ready for review March 15, 2023 14:47
@rbajollari rbajollari requested a review from a team as a code owner March 15, 2023 14:47
@zarazan
Copy link
Contributor

zarazan commented Mar 15, 2023

Why does the price-feeder need cosmwasm installed?

Its only for the umee version since its a dependency for importing umee

Ohhh. Should we make two separate Dockerfiles then?

@adamewozniak
Copy link
Member

adamewozniak commented Mar 15, 2023

Why does the price-feeder need cosmwasm installed?

Its only for the umee version since its a dependency for importing umee

Ohhh. Should we make two separate Dockerfiles then?

agree

^ nix that, don't need it since it's just separate branches

@rbajollari rbajollari merged commit 3b57e0c into umee Mar 16, 2023
@rbajollari rbajollari deleted the ryan/docker-build-fix branch March 16, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants