Add twitter card - #35
Merged
Merged
Conversation
Member
|
@avdata99 please test this locally with WP debugging turned on. I get the following error: Parse error: syntax error, unexpected end of file in /wp-content/themes/wordpress-theme/header.php on line 186 |
Member
Author
|
I add some curly braces here and it no longer gives the error @gocemitevski |
avdata99
force-pushed
the
34_twitter_card
branch
from
October 19, 2022 14:29
8e6ef93 to
0bfb2af
Compare
gocemitevski
requested changes
Oct 19, 2022
| <?php if ($twitter_thumb) { ?> | ||
| <meta name="twitter:image" value="<?php echo $twitter_thumb; ?>" /> | ||
| <?php } ?> | ||
| <meta name="twitter:site" value="@okfn" /> |
Member
Member
Author
There was a problem hiding this comment.
I've found the okfnwp_twitter_id theme option. Maybe it's better. Updated here @gocemitevski
Member
|
@avdata99 looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
This PR add Twitter card to headers.
I didn't manage to test locally but I assume it's ok